-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(SelectTable): should hidden append icon when hover #6757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the CSS class generation in SelectTable to apply the correct 'is-clearable' class when clearable, ensuring the clear icon is hidden on hover. Class diagram for updated SelectTable class attribute generationclassDiagram
class SelectTable {
- bool IsDisabled
- bool IsClearable
- IDictionary<string, object> AdditionalAttributes
+ string? ClassName
}
SelectTable : ClassName
ClassName --> CssBuilder
class CssBuilder {
+ static CssBuilder Default(string)
+ CssBuilder AddClass(string, bool)
+ CssBuilder AddClassFromAttributes(IDictionary<string, object>)
+ string Build()
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with the SelectTable component where the append icon was not properly hidden on hover. The fix updates the CSS class name used for clearable functionality.
- Updates CSS class name from "cls" to "is-clearable" for the IsClearable property
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6757 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31713 31713
Branches 4462 4462
=========================================
Hits 31713 31713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6756
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: