feat(AutoFill): reuse AutoComplete clear-icon function #6763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR refactors the AutoFill component to reuse the AutoComplete clear-icon functionality by removing its duplicate clear logic, delegating clear behavior to the TriggerFilter method, updating the razor markup accordingly, and adapting unit tests to exercise the new clear path. Sequence diagram for clear action in AutoFill after refactorsequenceDiagram
participant User as actor User
participant AutoFill
participant JSInterop
participant OnClearAsync
User->>AutoFill: Click clear icon
AutoFill->>AutoFill: TriggerFilter("")
AutoFill->>JSInterop: setValue(Id, "")
AutoFill->>OnClearAsync: (if exists) await OnClearAsync()
AutoFill->>AutoFill: Reset CurrentValue, _filterItems, _displayText
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the AutoFill component to reuse the AutoComplete clear-icon functionality by consolidating the clear logic into the existing TriggerFilter method instead of maintaining a separate OnClearValue method.
Key changes:
- Consolidates clear functionality into the
TriggerFiltermethod when an empty string is passed - Removes the duplicate
OnClearValuemethod and its click handler - Updates tests to use the unified clear mechanism
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AutoFill.razor.cs | Removes duplicate OnClearValue method and adds clear logic to TriggerFilter method |
| AutoFill.razor | Removes click handler from clear icon span element |
| AutoFillTest.cs | Updates tests to use TriggerFilter("") instead of clicking clear button |
| BootstrapBlazor.csproj | Increments version from 9.10.1 to 9.10.2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Ensure the clear-icon click is still wired up correctly after removing OnClearValue and the @OnClick, so that clicking it invokes TriggerFilter("") as intended.
- Consider reintroducing the virtualize element refresh in the empty-val branch of TriggerFilter to mirror the previous OnClearValue behavior and fully clear the dropdown.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the clear-icon click is still wired up correctly after removing OnClearValue and the @onclick, so that clicking it invokes TriggerFilter("") as intended.
- Consider reintroducing the virtualize element refresh in the empty-val branch of TriggerFilter to mirror the previous OnClearValue behavior and fully clear the dropdown.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/AutoFill/AutoFill.razor:22` </location>
<code_context>
<span class="form-select-append ac-loading"><i class="@LoadingIcon"></i></span>
@if (GetClearable())
{
- <span class="@ClearClassString" @onclick="OnClearValue"><i class="@ClearIcon"></i></span>
+ <span class="@ClearClassString"><i class="@ClearIcon"></i></span>
}
<RenderTemplate @ref="_dropdown">
</code_context>
<issue_to_address>
**issue (bug_risk):** Removing the @onclick handler from the clear icon may break expected clear functionality.
Without the click handler, users may lose the ability to clear the input. If this change was not intentional, please restore the handler or provide another way to clear the value.
</issue_to_address>
### Comment 2
<location> `test/UnitTest/Components/AutoFillTest.cs:428-430` </location>
<code_context>
Assert.Equal("2", searchText);
Assert.Contains("<div>test2</div>", cut.Markup);
+ // 测试 Clear 清空逻辑
query = false;
- // 点击 Clear 按钮
- var button = cut.Find(".clear-icon");
- await cut.InvokeAsync(() => button.Click());
+ await cut.InvokeAsync(() => cut.Instance.TriggerFilter(""));
Assert.True(query);
</code_context>
<issue_to_address>
**suggestion (testing):** Consider adding a test for clearing when the input is already empty.
Adding this test will verify that calling TriggerFilter("") on an already empty input does not introduce side effects and that the clear logic behaves consistently.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This was referenced Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6762
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Reuse AutoComplete's clear-icon functionality in AutoFill by removing the custom clearing handler and delegating clear events to TriggerFilter, ensuring component state resets correctly when cleared.
Bug Fixes:
Enhancements:
Tests: