-
-
Notifications
You must be signed in to change notification settings - Fork 362
chore(Sass): bump AspNetCore.SassCompiler 1.92.1 #6769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR upgrades the AspNetCore.SassCompiler to v1.92.1 and migrates the SCSS codebase from legacy @import statements to the modern @use module system, centralizing CSS variables in a dedicated file, updating theme entrypoints, injecting the variables module into all component styles, and cleaning up vendor-prefix patterns. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the AspNetCore.SassCompiler package from version 1.79.5 to 1.92.1 and restructures the SCSS module system to use modern @use directives instead of deprecated @import statements.
- Migrated from
@importto@usefor all SCSS module imports - Consolidated dark theme variables into the main variables file
- Updated Sass compiler source configuration and build targets
Reviewed Changes
Copilot reviewed 86 out of 86 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.targets | Updates SassCompiler package version and build message condition |
| sasscompiler.json | Changes source file from theme-specific to main components file |
| variables.scss | Adds dark theme variables previously in separate file |
| bootstrapblazor-dark.scss | Removed file - variables moved to main variables file |
| components.scss | Converted from @import to @use for all module imports |
| root.scss | Added @use directive for variables |
| Multiple component files | Added @use directives to import variables in each component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6769 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31718 31713 -5
Branches 4463 4463
=========================================
- Hits 31718 31713 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6768
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bump the Sass compiler to 1.92.1, migrate SCSS files to use the Sass module system, and consolidate theme variables including new dark mode settings.
New Features:
Bug Fixes:
Enhancements:
Build: