Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Sep 20, 2025

Link issues

fixes #6768

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bump the Sass compiler to 1.92.1, migrate SCSS files to use the Sass module system, and consolidate theme variables including new dark mode settings.

New Features:

  • Add dark theme variables for layout, dropdown, dial-button, and split components

Bug Fixes:

  • Fix Sass compilation errors by updating to AspNetCore.SassCompiler 1.92.1

Enhancements:

  • Migrate all SCSS imports from @import to @use to adopt the Sass module system
  • Remove deprecated bootstrapblazor-dark.scss and consolidate theme definitions in variables.scss
  • Refactor root.scss to use the variables module and apply consistent imports across components

Build:

  • Bump AspNetCore.SassCompiler to version 1.92.1
  • Update sasscompiler.json configuration for the new compiler version

Copilot AI review requested due to automatic review settings September 20, 2025 06:42
@bb-auto bb-auto bot added the chore This are tasks or bot action label Sep 20, 2025
@bb-auto bb-auto bot added this to the 9.10.0 milestone Sep 20, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 20, 2025

Reviewer's Guide

This PR upgrades the AspNetCore.SassCompiler to v1.92.1 and migrates the SCSS codebase from legacy @import statements to the modern @use module system, centralizing CSS variables in a dedicated file, updating theme entrypoints, injecting the variables module into all component styles, and cleaning up vendor-prefix patterns.

File-Level Changes

Change Details Files
Bump SassCompiler to v1.92.1
  • Update version in project build targets
  • Adjust sasscompiler.json config
src/BootstrapBlazor/Directory.Build.targets
src/BootstrapBlazor/sasscompiler.json
Replace @import with @use in global SCSS manifest
  • Switch components.scss from @import to @use
  • Remove deprecated dark-theme import
src/BootstrapBlazor/wwwroot/scss/components.scss
Centralize dark-mode variables in a new variables.scss
  • Rename and repurpose bootstrapblazor.scss to variables.scss
  • Define dark theme CSS variables for layout, dropdown, dial-button, split bar
src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss
src/BootstrapBlazor/wwwroot/scss/variables.scss
Inject shared variables into component SCSS files
  • Prepend @use of variables module in each component file
  • Remove in-file variable definitions
src/BootstrapBlazor/Components/**/*.razor.scss
Simplify user-select vendor prefixes
  • Remove comment markers around vendor prefixes
  • Condense multiple lines into a single user-select block
src/BootstrapBlazor/Components/DragDrap/DragDrop.razor.scss
Import variables in root stylesheet
  • Add @use "variables" as * at top of root.scss
src/BootstrapBlazor/wwwroot/scss/root.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#6768 Update the project to use AspNetCore.SassCompiler version 1.92.1.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the AspNetCore.SassCompiler package from version 1.79.5 to 1.92.1 and restructures the SCSS module system to use modern @use directives instead of deprecated @import statements.

  • Migrated from @import to @use for all SCSS module imports
  • Consolidated dark theme variables into the main variables file
  • Updated Sass compiler source configuration and build targets

Reviewed Changes

Copilot reviewed 86 out of 86 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Directory.Build.targets Updates SassCompiler package version and build message condition
sasscompiler.json Changes source file from theme-specific to main components file
variables.scss Adds dark theme variables previously in separate file
bootstrapblazor-dark.scss Removed file - variables moved to main variables file
components.scss Converted from @import to @use for all module imports
root.scss Added @use directive for variables
Multiple component files Added @use directives to import variables in each component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Sep 20, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (61e7c08) to head (61f3619).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6769   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31718     31713    -5     
  Branches      4463      4463           
=========================================
- Hits         31718     31713    -5     
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit cedd988 into main Sep 20, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the refactor-sass branch September 20, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Sass): bump AspNetCore.SassCompiler 1.92.1

2 participants