Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Sep 23, 2025

Link issues

fixes #6776

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update Bar chart sample to display data labels by default and use decimal data values

Enhancements:

  • Enable ShowDataLabel option in Bar chart sample
  • Convert sample Bar chart data values to floats for label formatting demonstration

Copilot AI review requested due to automatic review settings September 23, 2025 02:49
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Bar chart sample to showcase custom label formatting by enabling data labels and switching to decimal data points, and it updates the server project file to reference the chart library version that includes the new formatter support.

Class diagram for updated Bar chart sample data initialization

classDiagram
    class ChartDataSource {
        Options : ChartOptions
        Labels : IEnumerable<string>
        Data : List<ChartDataset>
    }
    class ChartOptions {
        Title : string
        ShowDataLabel : bool
        X : AxisOptions
        Y : AxisOptions
    }
    class AxisOptions {
        Title : string
        Stacked : bool
    }
    class ChartDataset {
        Label : string
        Data : IEnumerable<object>
    }
    ChartDataSource --> ChartOptions : has
    ChartDataSource --> ChartDataset : contains
    ChartOptions --> AxisOptions : has X, Y
    ChartDataSource : +OnInit(bool stacked, bool setTitle = true)
    ChartOptions : +ShowDataLabel (added)
    ChartDataset : +Data (now decimal values)
Loading

File-Level Changes

Change Details Files
Enhance Bar chart sample for custom label formatting
  • Enable data labels by setting Options.ShowDataLabel = true
  • Generate decimal data points by dividing random values by 10.0f
src/BootstrapBlazor.Server/Components/Samples/Charts/Bar.razor.cs
Update server project reference for label formatter support
  • Bump chart library version in BootstrapBlazor.Server.csproj
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#6776 Enable Chart DataLabel to display decimal values instead of rounding to integers.
#6776 Allow customization of the DataLabel formatter for Chart components, so users can control how numbers are displayed.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Sep 23, 2025
@bb-auto bb-auto bot added this to the 9.10.0 milestone Sep 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes chart custom label formatter support by enabling data labels and updating chart data generation to use decimal values instead of integers, along with upgrading the BootstrapBlazor.Chart package version.

  • Enables data labels on bar charts by setting ShowDataLabel = true
  • Changes chart data generation to produce decimal values (dividing by 10.0f) for better label formatting demonstration
  • Updates BootstrapBlazor.Chart package from version 9.0.0 to 9.0.1

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Bar.razor.cs Enables data labels and modifies data generation to use decimal values
BootstrapBlazor.Server.csproj Updates BootstrapBlazor.Chart package to version 9.0.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang merged commit a0dc0f0 into main Sep 23, 2025
4 of 5 checks passed
@ArgoZhang ArgoZhang deleted the feat-chart branch September 23, 2025 02:49
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a4748c4) to head (99a3aed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6778   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31721     31721           
  Branches      4464      4464           
=========================================
  Hits         31721     31721           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Chart): 柱状图的数据显示(ShowDataLabel)支持小数

2 participants