-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Layout): compatible net10 when href is # #6794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the MenuLink component by removing the special-case logic that defaulted to NavLinkMatch.All when the URL was empty, and instead always uses the user-configured Match value, ensuring compatibility with .NET 10 when href is '#'. Class diagram for updated MenuLink component logicclassDiagram
class MenuLink {
- IStringLocalizer<Menu> Localizer
- NavLinkMatch ItemMatch
- string? IconString
}
class Menu {
}
MenuLink --> Menu : uses Localizer
MenuLink --> NavLinkMatch : uses ItemMatch
MenuLink --> CssBuilder : uses IconString
class NavLinkMatch {
}
class CssBuilder {
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a compatibility issue with .NET 10 when href is "#" by simplifying the logic for determining NavLinkMatch behavior in MenuLink components.
- Removes conditional logic that was causing issues with .NET 10 compatibility
- Simplifies the ItemMatch property to directly return Item.Match
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6794 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31744 31743 -1
Branches 4468 4467 -1
=========================================
- Hits 31744 31743 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6793
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: