Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Sep 28, 2025

Link issues

fixes #6793

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Remove special-case fallback to NavLinkMatch.All for empty URLs in MenuLink, ensuring consistent matching behavior when href is '#'

Copilot AI review requested due to automatic review settings September 28, 2025 01:09
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the MenuLink component by removing the special-case logic that defaulted to NavLinkMatch.All when the URL was empty, and instead always uses the user-configured Match value, ensuring compatibility with .NET 10 when href is '#'.

Class diagram for updated MenuLink component logic

classDiagram
    class MenuLink {
        - IStringLocalizer<Menu> Localizer
        - NavLinkMatch ItemMatch
        - string? IconString
    }
    class Menu {
    }
    MenuLink --> Menu : uses Localizer
    MenuLink --> NavLinkMatch : uses ItemMatch
    MenuLink --> CssBuilder : uses IconString
    class NavLinkMatch {
    }
    class CssBuilder {
    }
Loading

File-Level Changes

Change Details Files
Simplify ItemMatch logic to use configured Match value unconditionally
  • Removed the conditional check for empty or whitespace Item.Url
  • Replaced the fallback to NavLinkMatch.All with direct return of Item.Match
src/BootstrapBlazor/Components/Menu/MenuLink.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6793 Make the Layout component compatible with .NET 10 when href is '#'.
#6793 Support bind-Value/OnValueChanged event callback in the Layout component. The PR only changes the logic for determining NavLinkMatch in MenuLink.razor.cs and does not add or modify any code related to bind-Value or OnValueChanged event callbacks.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Sep 28, 2025
@bb-auto bb-auto bot added this to the 9.10.0 milestone Sep 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compatibility issue with .NET 10 when href is "#" by simplifying the logic for determining NavLinkMatch behavior in MenuLink components.

  • Removes conditional logic that was causing issues with .NET 10 compatibility
  • Simplifies the ItemMatch property to directly return Item.Match

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Sep 28, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit c183310 into main Sep 28, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-menu branch September 28, 2025 01:12
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d451a73) to head (c9ddf09).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6794   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31744     31743    -1     
  Branches      4468      4467    -1     
=========================================
- Hits         31744     31743    -1     
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Layout): compatible net10 when href is #

2 participants