Skip to content

Conversation

@ljmay168
Copy link
Contributor

@ljmay168 ljmay168 commented Sep 28, 2025

Link issues

fixes #6797

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Exclude detail rows from table operations to ensure accurate column width calculations and copying functionality

Bug Fixes:

  • Filter out .is-detail rows when auto-fitting column widths
  • Exclude .is-detail rows when determining copyable column content

Copilot AI and others added 5 commits September 28, 2025 11:41
* Initial plan

* Implemented fix for multiple dialog scrolling issue

Co-authored-by: ArgoZhang <[email protected]>

* fix: 多级弹窗窗体内滚动

* Revert "Implemented fix for multiple dialog scrolling issue"

This reverts commit 42c4136.

* chore: bump version 9.10.3

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: ArgoZhang <[email protected]>
Co-authored-by: Argo Zhang <[email protected]>
@bb-auto
Copy link

bb-auto bot commented Sep 28, 2025

Thanks for your PR, @ljmay168. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhance table row selection logic by excluding detail rows (with class .is-detail) from DOM queries, ensuring that operations like automatic column width fitting and copy-column functionality only consider primary data rows.

Class diagram for table row selection update in Table.razor.js

classDiagram
    class Table {
        body
        thead
        tables
    }
    class TableRow {
        +isDetail: bool
    }
    Table "1" -- "*" TableRow : contains
    TableRow : .is-detail (excluded from selection)
    Table : autoFitColumnWidth()
    Table : setCopyColumn()
Loading

File-Level Changes

Change Details Files
Exclude detail rows (.is-detail) from table DOM row queries
  • Update autoFitColumnWidth’s head and body selectors to use > tr:not(.is-detail)
  • Update setCopyColumn’s three row selectors to use tr:not(.is-detail)
src/BootstrapBlazor/Components/Table/Table.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#6797 Fix the bug where double-clicking the table header to auto-resize column width does not work correctly when the table has detail rows (only the first column works, others throw errors).
#6797 Ensure that auto-resizing columns by double-clicking the header works for all columns, even when the table contains detail rows.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Sep 28, 2025
@bb-auto bb-auto bot requested a review from ArgoZhang September 28, 2025 05:48
@bb-auto bb-auto bot added this to the 9.10.0 milestone Sep 28, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Sep 28, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ljmay168
Copy link
Contributor Author

@microsoft-github-policy-service agree

@ljmay168 ljmay168 changed the title Dev feature fix(Table): 双击表头自动调整列宽功能在表格有明细行时不能正常工作 Sep 28, 2025
ArgoZhang
ArgoZhang previously approved these changes Sep 28, 2025
@ArgoZhang ArgoZhang dismissed stale reviews from sourcery-ai[bot] and themself via 6baef74 September 28, 2025 08:25
@ArgoZhang ArgoZhang changed the title fix(Table): 双击表头自动调整列宽功能在表格有明细行时不能正常工作 fix(Table): filter out .is-detail rows when auto-fitting column widths Sep 28, 2025
@ArgoZhang ArgoZhang merged commit 06c5b30 into dotnetcore:main Sep 28, 2025
4 checks passed
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3d09b91) to head (6baef74).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6800   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31748     31748           
  Branches      4464      4464           
=========================================
  Hits         31748     31748           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ljmay168 ljmay168 deleted the dev-feature branch October 10, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Table): 双击表头自动调整列宽功能在表格有明细行时不能正常工作

2 participants