-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(Table): filter out .is-detail rows when auto-fitting column widths #6800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Initial plan * Implemented fix for multiple dialog scrolling issue Co-authored-by: ArgoZhang <[email protected]> * fix: 多级弹窗窗体内滚动 * Revert "Implemented fix for multiple dialog scrolling issue" This reverts commit 42c4136. * chore: bump version 9.10.3 --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ArgoZhang <[email protected]> Co-authored-by: Argo Zhang <[email protected]>
Merge branch 'dev-feature' of https://github.com/ljmay168/BootstrapBlazor into dev-feature
|
Thanks for your PR, @ljmay168. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnhance table row selection logic by excluding detail rows (with class Class diagram for table row selection update in Table.razor.jsclassDiagram
class Table {
body
thead
tables
}
class TableRow {
+isDetail: bool
}
Table "1" -- "*" TableRow : contains
TableRow : .is-detail (excluded from selection)
Table : autoFitColumnWidth()
Table : setCopyColumn()
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@microsoft-github-policy-service agree |
6baef74
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6800 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31748 31748
Branches 4464 4464
=========================================
Hits 31748 31748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6797
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Exclude detail rows from table operations to ensure accurate column width calculations and copying functionality
Bug Fixes: