-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Console): remove console log in scripts #6802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes extraneous console.log debug statements from various components and changes one log to console.error for unsupported media device enumeration. Class diagram for updated media module loggingclassDiagram
class media {
+enumerateDevices()
}
media : -console.log("enumerateDevices() not supported.") [removed]
media : +console.error("enumerateDevices() not supported.") [added]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes debug console logging statements from JavaScript files across the codebase to clean up production code. The changes improve code quality by removing unnecessary debugging output that shouldn't be present in production builds.
Key changes:
- Changed
console.logtoconsole.errorfor an error condition in media device enumeration - Removed debug console logging and unused variable declarations from camera functionality
- Removed debug console logging from mind map and footer counter components
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/BootstrapBlazor/wwwroot/modules/media.js | Changed console.log to console.error for unsupported media devices |
| src/BootstrapBlazor/Components/Camera/Camera.razor.js | Removed unused variable and debug console logging |
| src/BootstrapBlazor.Server/Components/Samples/MindMaps.razor.js | Removed debug console logging from callback function |
| src/BootstrapBlazor.Server/Components/Components/FooterCounter.razor.js | Removed debug console logging from update function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6802 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31748 31748
Branches 4464 4464
=========================================
Hits 31748 31748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6801
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove console.log debug statements from various scripts and improve error logging for unsupported media device enumeration
Enhancements: