Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Sep 28, 2025

Link issues

fixes #6801

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove console.log debug statements from various scripts and improve error logging for unsupported media device enumeration

Enhancements:

  • Remove debug console.log of supportedConstraints in Camera.razor.js
  • Remove console.log from MindMaps clickCustom callback
  • Replace console.log with console.error for unsupported enumerateDevices in media.js
  • Remove console.log output in FooterCounter.razor.js

Copilot AI review requested due to automatic review settings September 28, 2025 08:13
@bb-auto bb-auto bot added the enhancement New feature or request label Sep 28, 2025
@bb-auto bb-auto bot added this to the 9.10.0 milestone Sep 28, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes extraneous console.log debug statements from various components and changes one log to console.error for unsupported media device enumeration.

Class diagram for updated media module logging

classDiagram
class media {
  +enumerateDevices()
}
media : -console.log("enumerateDevices() not supported.") [removed]
media : +console.error("enumerateDevices() not supported.") [added]
Loading

File-Level Changes

Change Details Files
Removed debug console.log statements
  • Removed supportedConstraints log in camera component
  • Removed clickCustom callback args log in MindMap sample
  • Removed FooterCounter update log
src/BootstrapBlazor/Components/Camera/Camera.razor.js
src/BootstrapBlazor.Server/Components/Samples/MindMaps.razor.js
src/BootstrapBlazor.Server/Components/Components/FooterCounter.razor.js
Replaced console.log with console.error for unsupported device enumeration
  • Updated enumerateDevices() unsupported message to use console.error
src/BootstrapBlazor/wwwroot/modules/media.js

Assessment against linked issues

Issue Objective Addressed Explanation
#6801 Remove all console.log statements from scripts in the codebase.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes debug console logging statements from JavaScript files across the codebase to clean up production code. The changes improve code quality by removing unnecessary debugging output that shouldn't be present in production builds.

Key changes:

  • Changed console.log to console.error for an error condition in media device enumeration
  • Removed debug console logging and unused variable declarations from camera functionality
  • Removed debug console logging from mind map and footer counter components

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/BootstrapBlazor/wwwroot/modules/media.js Changed console.log to console.error for unsupported media devices
src/BootstrapBlazor/Components/Camera/Camera.razor.js Removed unused variable and debug console logging
src/BootstrapBlazor.Server/Components/Samples/MindMaps.razor.js Removed debug console logging from callback function
src/BootstrapBlazor.Server/Components/Components/FooterCounter.razor.js Removed debug console logging from update function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang merged commit 3d09b91 into main Sep 28, 2025
4 of 5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-js branch September 28, 2025 08:13
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8422a3f) to head (ba8e5d5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6802   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31748     31748           
  Branches      4464      4464           
=========================================
  Hits         31748     31748           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Console): remove console log in scripts

2 participants