-
-
Notifications
You must be signed in to change notification settings - Fork 362
test(Scss): fix variable check test #6815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refactors the SCSS variable check unit test by updating the test class constructor for xUnit output injection, correcting the target SCSS file path, and standardizing regex match conditions. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a test file for Sass variable checking by modernizing the constructor pattern and correcting the file path reference used in the test.
- Updates constructor to use primary constructor syntax
- Corrects the variable file path from
bootstrapblazor.scsstovariables.scss - Replaces
.Any()calls with.Count != 0for performance optimization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| namespace UniTest.Sass; | ||
|
|
||
| public partial class VariableTest | ||
| public partial class VariableTest(ITestOutputHelper testOutputHelper) |
Copilot
AI
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary constructor parameter testOutputHelper is captured but never used in the class. Consider storing it in a field or property if it's needed for test output, or remove it if it's not required.
| public partial class VariableTest(ITestOutputHelper testOutputHelper) | |
| public partial class VariableTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6815 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31751 31751
Branches 4465 4465
=========================================
Hits 31751 31751
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6814
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix SCSS variable unit test by aligning file paths, simplifying test helper injection, and correcting regex match conditions
Tests: