-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(Table): should reset column after call ResetVisibleColumns #6828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where table columns were not being properly reset after calling ResetVisibleColumns when column resizing is enabled. The fix ensures that the _resetColumns flag is set to true when AllowResizing is enabled, which triggers the necessary column reset behavior.
- Added conditional logic to set
_resetColumns = truewhenAllowResizingis enabled - Updated version number from 9.11.1-beta03 to 9.11.1-beta04
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BootstrapBlazor/Components/Table/Table.razor.cs | Added logic to set _resetColumns flag when AllowResizing is enabled in ResetVisibleColumns method |
| src/BootstrapBlazor/BootstrapBlazor.csproj | Updated version number to 9.11.1-beta04 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnhanced the ResetVisibleColumns method to include a resizing-aware reset flag, ensuring that when column resizing is enabled, a full column reset is triggered and the UI updates accordingly. Sequence diagram for ResetVisibleColumns with resizing-aware resetsequenceDiagram
participant TableComponent
participant UI
TableComponent->>TableComponent: ResetVisibleColumns(columns)
alt AllowResizing is true
TableComponent->>TableComponent: _resetColumns = true
end
TableComponent->>TableComponent: InternalResetVisibleColumns(Columns, columns)
TableComponent->>UI: StateHasChanged()
Class diagram for Table component changesclassDiagram
class TableComponent {
+bool AllowResizing
+bool _resetColumns
+void ResetVisibleColumns(IEnumerable<ColumnVisibleItem> columns)
-void InternalResetVisibleColumns(List<ITableColumn> columns, IEnumerable<ColumnVisibleItem> columns)
}
TableComponent : ResetVisibleColumns() --> InternalResetVisibleColumns()
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6828 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 739 739
Lines 31751 31755 +4
Branches 4465 4466 +1
===========================================
Hits 31751 31751
- Misses 0 3 +3
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6823
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Ensure that visible columns are properly reset when calling ResetVisibleColumns on a resizable table
Bug Fixes: