Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 8, 2025

Link issues

fixes #6840

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Configure CSS bundler tooling and remove legacy CSS bundles, and refine sample components with explicit markup and localized display texts

New Features:

  • Introduce CSS bundling support via new dotnet-tools.json and bundler.json configuration

Enhancements:

  • Update ColorPicker samples to use explicit opening and closing tags
  • Localize Switch DisplayText in sample components

Build:

  • Add CSS bundler tooling configuration to the repository

Chores:

  • Remove pre-generated CSS bundle files from wwwroot
  • Update .gitignore to account for CSS bundler outputs

Copilot AI review requested due to automatic review settings October 8, 2025 05:27
@bb-auto bb-auto bot added the chore This are tasks or bot action label Oct 8, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 8, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 8, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR integrates a CSS bundler into the build pipeline and updates the component sample markup and localization resources.

Class diagram for updated ColorPickers sample markup

classDiagram
    class ColorPicker {
        +Value
        +IsDisabled
        +IsSupportOpacity
    }
    class DemoBlock {
        +Title
        +Introduction
        +Name
    }
    class Switch {
        +Value
        +DisplayText
        +ShowLabel
    }
    class ValidateForm {
        +Model
    }
    DemoBlock "1" *-- "1" ColorPicker : contains
    DemoBlock "1" *-- "1" Switch : contains
    ValidateForm "1" *-- "1" ColorPicker : contains
Loading

File-Level Changes

Change Details Files
Integrate CSS bundler tooling into the project
  • Added dotnet-tools.json to pin the css-bundler CLI
  • Introduced bundler.json configuration for bundle inputs and outputs
  • Updated csproj and Directory.Build.targets to invoke css-bundler during build
  • Removed pre-generated bundle CSS files from wwwroot
dotnet-tools.json
src/BootstrapBlazor/bundler.json
src/BootstrapBlazor/BootstrapBlazor.csproj
src/BootstrapBlazor/Directory.Build.targets
src/BootstrapBlazor/wwwroot/css/bootstrap.blazor.bundle.min.css
src/BootstrapBlazor/wwwroot/css/bootstrap.blazor.bundle.rtl.min.css
Refactor sample component markup in ColorPickers.razor
  • Converted self-closing ColorPicker tags to explicit opening/closing form
  • Ensured @bind-Value usages are closed consistently
  • Updated markup indentation for readability
src/BootstrapBlazor.Server/Components/Samples/ColorPickers.razor
Enhance localization for Switch control labels
  • Replaced hardcoded DisplayText on Switch with Localizer references
  • Added SupportOpacity and Disabled keys to locale JSONs
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json

Assessment against linked issues

Issue Objective Addressed Explanation
#6840 Add css-bundler tools to the repository (including configuration and/or tool files).
#6840 Remove previously bundled CSS files that are now handled by the css-bundler tools.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces CSS bundling functionality by replacing CSS @import statements with a build-time bundling tool. The changes implement a css-bundler tool to concatenate CSS files during the build process instead of relying on browser @import directives.

  • Adds css-bundler tooling configuration and build targets to automatically bundle CSS files
  • Updates localization files with new strings for ColorPicker component
  • Makes minor code style improvements to ColorPicker component markup

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
dotnet-tools.json Adds bootstrapblazor.cssbundler tool configuration
src/BootstrapBlazor/bundler.json Configures CSS bundling inputs and outputs
src/BootstrapBlazor/Directory.Build.targets Adds CssBundler MSBuild target to execute bundling
src/BootstrapBlazor/BootstrapBlazor.csproj Updates version and refines content inclusion patterns
src/BootstrapBlazor/wwwroot/css/bootstrap.blazor.bundle*.css Removes @import statements to be replaced by bundled content
src/BootstrapBlazor.Server/Locales/*.json Adds localization for ColorPicker component
src/BootstrapBlazor.Server/Components/Samples/ColorPickers.razor Updates component markup and localization usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 8, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (04bec17) to head (43cb668).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6841   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31755     31755           
  Branches      4466      4466           
=========================================
  Hits         31755     31755           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 217da3d into main Oct 8, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the feat-tools branch October 8, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(CssBundler): add css-bundler tools

2 participants