-
-
Notifications
You must be signed in to change notification settings - Fork 362
chore(CssBundler): add css-bundler tools #6841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR integrates a CSS bundler into the build pipeline and updates the component sample markup and localization resources. Class diagram for updated ColorPickers sample markupclassDiagram
class ColorPicker {
+Value
+IsDisabled
+IsSupportOpacity
}
class DemoBlock {
+Title
+Introduction
+Name
}
class Switch {
+Value
+DisplayText
+ShowLabel
}
class ValidateForm {
+Model
}
DemoBlock "1" *-- "1" ColorPicker : contains
DemoBlock "1" *-- "1" Switch : contains
ValidateForm "1" *-- "1" ColorPicker : contains
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces CSS bundling functionality by replacing CSS @import statements with a build-time bundling tool. The changes implement a css-bundler tool to concatenate CSS files during the build process instead of relying on browser @import directives.
- Adds css-bundler tooling configuration and build targets to automatically bundle CSS files
- Updates localization files with new strings for ColorPicker component
- Makes minor code style improvements to ColorPicker component markup
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
dotnet-tools.json |
Adds bootstrapblazor.cssbundler tool configuration |
src/BootstrapBlazor/bundler.json |
Configures CSS bundling inputs and outputs |
src/BootstrapBlazor/Directory.Build.targets |
Adds CssBundler MSBuild target to execute bundling |
src/BootstrapBlazor/BootstrapBlazor.csproj |
Updates version and refines content inclusion patterns |
src/BootstrapBlazor/wwwroot/css/bootstrap.blazor.bundle*.css |
Removes @import statements to be replaced by bundled content |
src/BootstrapBlazor.Server/Locales/*.json |
Adds localization for ColorPicker component |
src/BootstrapBlazor.Server/Components/Samples/ColorPickers.razor |
Updates component markup and localization usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6841 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31755 31755
Branches 4466 4466
=========================================
Hits 31755 31755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6840
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Configure CSS bundler tooling and remove legacy CSS bundles, and refine sample components with explicit markup and localized display texts
New Features:
Enhancements:
Build:
Chores: