chore(Action): add cache nuget step #6845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideCI workflows are enhanced to cache NuGet packages via actions/cache, add explicit dotnet restore steps (removing the no-cache flag), and the push triggers are simplified by dropping the ‘dev’ branch. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds NuGet package caching to GitHub Actions workflows to improve build performance by caching dependencies between runs. It also removes the "dev" branch from workflow triggers and reorganizes dependency restoration steps.
- Adds NuGet package caching using
actions/cache@v4in three workflow files - Removes "dev" branch from workflow triggers in build and auto-pull-request-checks workflows
- Consolidates dependency restoration by adding explicit restore steps and removing
--no-cacheflag
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/pack.yml | Adds NuGet caching and explicit restore step |
| .github/workflows/build.yml | Adds NuGet caching, removes dev branch trigger, updates restore process |
| .github/workflows/auto-pull-request-checks.yml | Adds NuGet caching, removes dev branch trigger, adds explicit restore step |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/build.yml:25` </location>
<code_context>
+ uses: actions/cache@v4
+ with:
+ path: ~/.nuget/packages
+ key: ${{runner.os}}-nuget-bb-${{hashFiles('**/*.csproj')}}
+ restore-keys: |
+ ${{runner.os}}-nuget-bb-
</code_context>
<issue_to_address>
**issue (bug_risk):** Potential invisible Unicode characters in cache key glob pattern.
Please check for and remove any hidden Unicode characters in the glob pattern to ensure correct cache key matching.
</issue_to_address>
### Comment 2
<location> `.github/workflows/auto-pull-request-checks.yml:26` </location>
<code_context>
+ uses: actions/cache@v4
+ with:
+ path: ~/.nuget/packages
+ key: ${{runner.os}}-nuget-bb-${{hashFiles('**/*.csproj')}}
+ restore-keys: |
+ ${{runner.os}}-nuget-bb-
</code_context>
<issue_to_address>
**issue (bug_risk):** Invisible Unicode characters may be present in the cache key glob pattern.
Please verify that the glob pattern does not include any zero-width or invisible Unicode characters to prevent cache key mismatches.
</issue_to_address>
### Comment 3
<location> `.github/workflows/pack.yml:29` </location>
<code_context>
+ uses: actions/cache@v4
+ with:
+ path: ~/.nuget/packages
+ key: ${{runner.os}}-nuget-bb-${{hashFiles('**/*.csproj')}}
+ restore-keys: |
+ ${{runner.os}}-nuget-bb-
</code_context>
<issue_to_address>
**issue (bug_risk):** Possible invisible Unicode characters in cache key glob pattern.
Check for and remove any hidden Unicode characters in the glob pattern to prevent cache misses.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6845 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31755 31755
Branches 4466 4466
=========================================
Hits 31755 31755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6844
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve CI efficiency by caching NuGet packages and streamlining dependency restoration across workflows, and remove outdated branch trigger.
Enhancements: