doc(GlobalSearch): update component css #6852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refines the GlobalSearch component's CSS by switching to CSS variables for border colors, improving spacing and typography, and removes the unused Meilisearch SCSS import and file. Class diagram for removal of Meilisearch SCSS import and fileclassDiagram
class ComponentsSCSS {
-meilisearch.scss
}
class MeilisearchSCSS {
}
ComponentsSCSS o-- MeilisearchSCSS
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
Updates the GlobalSearch component CSS styling by removing centralized MeiliSearch styles and moving them to a component-specific location. This change improves CSS organization and allows for more targeted styling of the global search functionality.
- Removed the centralized
meilisearch.scssfile and its import - Added component-specific CSS rules for the global search in
Header.razor.css - Updated the MeiliSearch package version to 9.1.11
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/BootstrapBlazor/wwwroot/scss/meilisearch.scss | Removed entire file containing global search styles |
| src/BootstrapBlazor/wwwroot/scss/components.scss | Removed import of meilisearch.scss |
| src/BootstrapBlazor.Server/Components/Components/Header.razor.css | Added component-specific global search styles with improved CSS properties |
| src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj | Updated MeiliSearch package version from 9.1.10 to 9.1.11 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+75
to
+85
| ::deep .bb-g-search .search-dialog-icon { | ||
| font-size: 0.875rem; | ||
| } | ||
|
|
||
| ::deep .bb-g-search > input { | ||
| padding: 2px 0; | ||
| } | ||
|
|
||
| ::deep .bb-g-search > input::placeholder { | ||
| color: var(--bb-header-dropdown-color); | ||
| } |
There was a problem hiding this comment.
Inconsistent CSS indentation. Lines 75-85 should have consistent indentation - either all at the same level or properly nested to reflect the CSS hierarchy.
Suggested change
| ::deep .bb-g-search .search-dialog-icon { | |
| font-size: 0.875rem; | |
| } | |
| ::deep .bb-g-search > input { | |
| padding: 2px 0; | |
| } | |
| ::deep .bb-g-search > input::placeholder { | |
| color: var(--bb-header-dropdown-color); | |
| } | |
| ::deep .bb-g-search .search-dialog-icon { | |
| font-size: 0.875rem; | |
| } | |
| ::deep .bb-g-search > input { | |
| padding: 2px 0; | |
| } | |
| ::deep .bb-g-search > input::placeholder { | |
| color: var(--bb-header-dropdown-color); | |
| } |
| --bb-border-hover-color: var(--bb-header-dropdown-border-hover-color); | ||
| width: var(--bb-header-select-width); | ||
| margin-bottom: var(--bb-header-search-margin-bottom); | ||
| margin-block-end: var(--bb-header-search-margin-bottom); |
There was a problem hiding this comment.
Changed from margin-bottom to margin-block-end for better internationalization support, but this should be consistently applied throughout the file for similar properties.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6852 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31755 31755
Branches 4466 4466
=========================================
Hits 31755 31755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6851
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refine global search component styling and remove obsolete meilisearch styles
Bug Fixes:
Enhancements:
Chores: