Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 10, 2025

Link issues

fixes #6855

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enable and improve support for the OnAutoFitContentAsync callback in the Table component, using the callback's returned width when provided and falling back to automatic cell measurement otherwise.

Enhancements:

  • Register AutoFitContentCallback only when OnAutoFitContentAsync is set to avoid null callback calls
  • Guard the JavaScript AutoFitContent callback invocation and initialize width from its return value
  • Fall back to measuring cell widths only if the callback returns zero

Copilot AI review requested due to automatic review settings October 10, 2025 00:59
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 10, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 10, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhances the table component’s auto-fit feature by making the OnAutoFitContentAsync callback optional and using its returned width as the initial measurement before falling back to DOM-based width calculations.

Class diagram for updated Table component auto-fit logic

classDiagram
class Table {
  +OnAutoFitContentAsync: Func<string, Task<int>>
  +AutoFitContentCallback: string | null
}
Table --|> "uses" OnAutoFitContentAsync
class TableJs {
  +autoFitColumnWidth(table, col)
}
TableJs ..> Table : uses Table.options.AutoFitContentCallback
TableJs ..> OnAutoFitContentAsync : invokes if not null
Loading

File-Level Changes

Change Details Files
Optional invocation of the auto-fit callback
  • Initialize widthValue to zero
  • Invoke autoFitContentCallback only if it's non-null
src/BootstrapBlazor/Components/Table/Table.razor.js
Use callback result as initial maxWidth with fallback
  • Set maxWidth to the callback's return value initially
  • Compute cell widths only when the callback returns zero
src/BootstrapBlazor/Components/Table/Table.razor.js
Conditionally set AutoFitContentCallback in JS initialization
  • Pass null for AutoFitContentCallback when OnAutoFitContentAsync is null
  • Keep other callbacks unchanged
src/BootstrapBlazor/Components/Table/Table.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6855 Make the OnAutoFitContentAsync callback work in the Table component, so that column width can be auto-fitted using the callback if provided.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the OnAutoFitContentAsync functionality for the Table component by adding proper null checking and handling for the auto-fit content callback.

  • Added null safety checks for the auto-fit content callback before invoking it
  • Modified the width calculation logic to use callback results when available or fall back to automatic calculation
  • Updated the callback registration to only set the callback name when OnAutoFitContentAsync is not null

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Table.razor.js Added null checking for autoFitContentCallback and improved width calculation logic
Table.razor.cs Modified callback registration to conditionally set AutoFitContentCallback based on OnAutoFitContentAsync availability

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Components/Table/Table.razor.js:731-732` </location>
<code_context>
-        const cell = row.cells[index];
-        maxWidth = Math.max(maxWidth, calcCellWidth(cell));
-    });
+    let maxWidth = widthValue;
+    if (maxWidth === 0) {
+        [...rows].forEach(row => {
+            const cell = row.cells[index];
</code_context>

<issue_to_address>
**issue (bug_risk):** Initial maxWidth assignment may cause issues if widthValue is negative.

If widthValue is negative, maxWidth will remain invalid since the recalculation is skipped. Check for widthValue > 0 to ensure only valid widths are used.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cbb85fb) to head (0d05de6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6856   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31755     31755           
  Branches      4466      4466           
=========================================
  Hits         31755     31755           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 826819f into main Oct 10, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch October 10, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): make OnAutoFitContentAsync work

2 participants