Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 13, 2025

Link issues

fixes #6884

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Enable preview in wasm mode by retrieving files from inputFile.files when Data.get(id).files is undefined

Copilot AI review requested due to automatic review settings October 13, 2025 03:11
@bb-auto bb-auto bot added the bug Something isn't working label Oct 13, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 13, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhanced the getPreviewUrl implementation to gracefully handle WASM mode by falling back to the inputFile element when the files array is unavailable, and streamlined the lookup logic.

Class diagram for updated upload data structure in getPreviewUrl

classDiagram
class Upload {
  files
  inputFile
}
class InputFile {
  files
}
Upload --> InputFile : contains
Loading

Flow diagram for getPreviewUrl logic update

flowchart TD
A["getPreviewUrl(id, fileName)"] --> B["upload = Data.get(id)"]
B --> C{"files exists?"}
C -- Yes --> D["fileList = files"]
C -- No --> E["fileList = inputFile.files"]
D --> F["Find file by name"]
E --> F
F --> G{"file found?"}
G -- Yes --> H["url = URL.createObjectURL(file)"]
G -- No --> I["url = ''"]
H --> J["return url"]
I --> J
Loading

File-Level Changes

Change Details Files
Support WASM mode in preview URL generation
  • Added inputFile to the destructured properties of the upload object
  • Switched source of files to use files or inputFile.files
  • Condensed nested conditionals into a single find and if check
src/BootstrapBlazor/wwwroot/modules/upload.js

Assessment against linked issues

Issue Objective Addressed Explanation
#6884 Fix the bug where the AvatarUpload component does not display a preview image after selecting a file in wasm mode.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the preview function to support WASM mode by modifying the file retrieval logic in the upload module. The change ensures that files can be accessed from either the files property or the inputFile.files property when one is not available.

  • Modified file retrieval logic to handle both files and inputFile.files properties
  • Simplified conditional structure by removing nested if statements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 13, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5c0be2f) to head (5fdb7dd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6889   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31765     31765           
  Branches      4466      4466           
=========================================
  Hits         31765     31765           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit c579ce1 into main Oct 13, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-upload branch October 13, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(AvatarUpload): wasm 模式下预览功能不正常

2 participants