Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 13, 2025

Link issues

fixes #6890

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Optimize table column visibility logic by replacing repeated Find calls with precomputed name lists and using Contains for faster lookups.

Enhancements:

  • Use a list of visible column names and Contains in GetVisibleColumns to filter columns
  • Use a distinct list of visible column names and Contains in GetColumnsListState to determine column list state

Copilot AI review requested due to automatic review settings October 13, 2025 04:37
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 13, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 13, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactored Table toolbar column visibility logic to improve performance by precomputing visible column name lists and using Contains for lookups instead of Find or DistinctBy.

Class diagram for updated Table toolbar column visibility logic

classDiagram
    class Table {
        +IEnumerable<ITableColumn> GetVisibleColumns()
        +bool GetColumnsListState(ColumnVisibleItem item)
        -List<ColumnVisibleItem> _visibleColumns
        -IEnumerable<ITableColumn> Columns
        -int ScreenSize
    }
    class ITableColumn {
        +bool Visible
        +string Name
        +string GetFieldName()
        +bool GetIgnore()
        +int ShownWithBreakPoint
    }
    class ColumnVisibleItem {
        +string Name
        +bool Visible
    }
    Table --> ITableColumn
    Table --> ColumnVisibleItem
Loading

File-Level Changes

Change Details Files
Optimize GetVisibleColumns filtering
  • Select only visible column names into a list
  • Use Contains to check if field names are in the visible list
  • Retain screen size breakpoint filtering
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs
Refactor GetColumnsListState logic
  • Build a distinct list of visible column names
  • Use Contains to check for a single visible column
  • Simplify count check using the list's Count
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6890 Refactor Table component to improve performance by using the Contains method instead of Find/Where for column visibility checks.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves Table component performance by optimizing column visibility lookup operations to use Contains() instead of Find() methods.

  • Replaces linear Find() searches with more efficient Contains() lookups using HashSet-like operations
  • Refactors the GetColumnsListState method to use a cleaner, more readable approach
  • Bumps version from 9.11.2-beta06 to 9.11.2-beta07

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs Optimizes column visibility checks by using Contains() instead of Find() and refactors GetColumnsListState method
src/BootstrapBlazor/BootstrapBlazor.csproj Version bump to 9.11.2-beta07

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 13, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider using a HashSet for the projected visible column names to get O(1) lookups and avoid repeated list allocations.
  • Right now GetColumnsListState rebuilds the visible names list on every call—extracting that projection into a shared helper or caching it would reduce redundant enumeration.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider using a HashSet<string> for the projected visible column names to get O(1) lookups and avoid repeated list allocations.
- Right now GetColumnsListState rebuilds the visible names list on every call—extracting that projection into a shared helper or caching it would reduce redundant enumeration.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c579ce1) to head (19d61f5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6891   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31765     31768    +3     
  Branches      4466      4467    +1     
=========================================
+ Hits         31765     31768    +3     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang
Copy link
Member Author

@sourcecy-ai review

@ArgoZhang ArgoZhang merged commit 940c31e into main Oct 13, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the refactor-table branch October 13, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Table): improve performance use Contains

2 participants