-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(FilterIcon): clear filter button in header row use ban icon #6897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the clear filter button’s icon to use the ‘ban’ icon in Bootstrap and the ‘cancel’ icon in Material Design by altering the corresponding CSS class values in the icon dictionaries. Class diagram for updated icon mappings in BootstrapIcons and MaterialDesignIconsclassDiagram
class BootstrapIcons {
+Dictionary<ComponentIcons, string> IconMappings
}
class MaterialDesignIcons {
+Dictionary<ComponentIcons, string> IconMappings
}
class ComponentIcons {
<<enumeration>>
FilterButtonClearIcon
FilterButtonFilterIcon
TableFilterPlusIcon
TableFilterMinusIcon
StepErrorIcon
}
BootstrapIcons --> ComponentIcons
MaterialDesignIcons --> ComponentIcons
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the filter clear button icons in the header row to use ban/cancel icons instead of filter-related icons for better visual distinction and user experience.
- Changes the FilterButtonClearIcon from filter-specific icons to ban/cancel icons
- Updates both Bootstrap Icons and Material Design Icons implementations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BootstrapBlazor/Icons/MaterialDesignIcons.cs | Updates FilterButtonClearIcon from "mdi-filter-remove-outline" to "mdi-cancel" |
| src/BootstrapBlazor/Icons/BootstrapIcons.cs | Updates FilterButtonClearIcon from "bi-funnel" to "bi-ban" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6897 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31768 31768
Branches 4467 4467
=========================================
Hits 31768 31768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6896
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Change the clear filter icon in the table header from a funnel to a ban/cancel icon across both Bootstrap and Material Design icon sets.
Bug Fixes: