-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(StringFilter): support auto filter after input filter text #6899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnable automatic filtering when the user types into the string filter by adding a dedicated change event handler and updating the input component’s binding to fire on each value change. Sequence diagram for automatic filter trigger on input changesequenceDiagram
actor User
participant "BootstrapInput"
participant "StringFilter"
participant "Filter Logic"
User->>"BootstrapInput": Type in filter text
"BootstrapInput"->>"StringFilter": OnValueChanged(val)
"StringFilter"->>"Filter Logic": OnFilterAsync()
"Filter Logic"-->>"StringFilter": Filter results updated
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements auto-filtering functionality for StringFilter components, allowing filters to automatically trigger when users input text rather than requiring manual filter activation.
- Replaced two-way data binding with explicit value change handling
- Added OnValueChanged method to automatically trigger filtering on input
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| StringFilter.razor | Updated BootstrapInput to use explicit value binding with OnValueChanged callback |
| StringFilter.razor.cs | Added OnValueChanged method to handle input changes and trigger automatic filtering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding a configurable debounce or delay in OnValueChanged so you don’t invoke the filter logic on every keystroke, which can improve performance on large data sets.
- Expose an optional parameter (e.g. AutoFilterEnabled) to let consumers opt into auto‐filtering on input change rather than making it always on by default.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a configurable debounce or delay in OnValueChanged so you don’t invoke the filter logic on every keystroke, which can improve performance on large data sets.
- Expose an optional parameter (e.g. AutoFilterEnabled) to let consumers opt into auto‐filtering on input change rather than making it always on by default.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Filters/StringFilter.razor.cs:132-135` </location>
<code_context>
await base.SetFilterConditionsAsync(filter);
}
+
+ private async Task OnValueChanged(string? val)
+ {
+ _value1 = val;
+ await OnFilterAsync();
+ }
}
</code_context>
<issue_to_address>
**issue (bug_risk):** OnValueChanged does not handle potential exceptions from OnFilterAsync.
Add error handling to OnValueChanged to catch exceptions from OnFilterAsync and prevent UI disruptions.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6899 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31768 31772 +4
Branches 4467 4467
=========================================
+ Hits 31768 31772 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6898
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhance StringFilter component to apply filters automatically on input value changes.
New Features: