Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 14, 2025

Link issues

fixes #6898

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhance StringFilter component to apply filters automatically on input value changes.

New Features:

  • StringFilter now triggers filtering automatically as the user types
  • Added OnValueChanged callback in StringFilter component to apply filter on input change

Copilot AI review requested due to automatic review settings October 14, 2025 03:33
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 14, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 14, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enable automatic filtering when the user types into the string filter by adding a dedicated change event handler and updating the input component’s binding to fire on each value change.

Sequence diagram for automatic filter trigger on input change

sequenceDiagram
    actor User
    participant "BootstrapInput"
    participant "StringFilter"
    participant "Filter Logic"
    User->>"BootstrapInput": Type in filter text
    "BootstrapInput"->>"StringFilter": OnValueChanged(val)
    "StringFilter"->>"Filter Logic": OnFilterAsync()
    "Filter Logic"-->>"StringFilter": Filter results updated
Loading

File-Level Changes

Change Details Files
Introduce OnValueChanged handler to trigger filtering on text input
  • Add private async OnValueChanged method in codebehind
  • Invoke OnFilterAsync within this handler
src/BootstrapBlazor/Components/Filters/StringFilter.razor.cs
Update BootstrapInput binding to use event callback
  • Replace @bind-Value with Value parameter
  • Wire OnValueChanged event to the new handler
src/BootstrapBlazor/Components/Filters/StringFilter.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6898 Enable automatic filtering in StringFilter component after inputting filter text.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements auto-filtering functionality for StringFilter components, allowing filters to automatically trigger when users input text rather than requiring manual filter activation.

  • Replaced two-way data binding with explicit value change handling
  • Added OnValueChanged method to automatically trigger filtering on input

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
StringFilter.razor Updated BootstrapInput to use explicit value binding with OnValueChanged callback
StringFilter.razor.cs Added OnValueChanged method to handle input changes and trigger automatic filtering

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider adding a configurable debounce or delay in OnValueChanged so you don’t invoke the filter logic on every keystroke, which can improve performance on large data sets.
  • Expose an optional parameter (e.g. AutoFilterEnabled) to let consumers opt into auto‐filtering on input change rather than making it always on by default.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a configurable debounce or delay in OnValueChanged so you don’t invoke the filter logic on every keystroke, which can improve performance on large data sets.
- Expose an optional parameter (e.g. AutoFilterEnabled) to let consumers opt into auto‐filtering on input change rather than making it always on by default.

## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor/Components/Filters/StringFilter.razor.cs:132-135` </location>
<code_context>
         await base.SetFilterConditionsAsync(filter);
     }
+
+    private async Task OnValueChanged(string? val)
+    {
+        _value1 = val;
+        await OnFilterAsync();
+    }
 }
</code_context>

<issue_to_address>
**issue (bug_risk):** OnValueChanged does not handle potential exceptions from OnFilterAsync.

Add error handling to OnValueChanged to catch exceptions from OnFilterAsync and prevent UI disruptions.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (940c31e) to head (0630c56).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6899   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31768     31772    +4     
  Branches      4467      4467           
=========================================
+ Hits         31768     31772    +4     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit ac482e0 into main Oct 14, 2025
8 checks passed
@ArgoZhang ArgoZhang deleted the feat-string-filter branch October 14, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(StringFilter): support auto filter after input filter text

2 participants