-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(SelectCity): disable AutoClose when set IsMultiple to true #6938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the SelectCity demo to reflect the new AutoClose behavior when IsMultiple is true by refactoring the sample markup and refreshing project configurations. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Disable AutoClose when SelectCity is in multi-select mode and adjust the sample to use two-way binding for Value.
- Switch SelectCity sample from one-way Value to @bind-Value
- Replace NuGet package reference for BootstrapBlazor.Region with a local ProjectReference and add it to the solution
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Components/Samples/SelectCities.razor | Update SelectCity usage to use @bind-Value and reorder props. |
| src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj | Comment out BootstrapBlazor.Region package; add ProjectReference to local Region project. |
| BootstrapBlazor.slnx | Add local Region project to the solution. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6938 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 740 740
Lines 31819 31819
Branches 4469 4469
=========================================
Hits 31819 31819
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6937
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Disable auto-close behavior for multi-select in SelectCity and update the sample to use two-way binding and improved formatting.
New Features:
Enhancements: