feat(NET10): add NET10 support #6940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/pack.yml
Reviewer's GuideThis PR extends support for .NET 10 by updating version references in documentation, samples, CI/CD workflows, and deployment scripts; it also refines scrolling behavior and adds a fallback NotFound page for undefined routes. Flow diagram for updated deployment script to .NET 10flowchart TD
A["dotnet publish src/BootstrapBlazor.Server -c Release"]
B["Copy publish output from net10.0 directory"]
C["Restart ba.blazor service"]
A --> B --> C
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `scripts/linux/deploy.sh:30` </location>
<code_context>
echo "*********************** install nginx ***********************"
yes|sudo apt install nginx
+mkdir /usr/share/nginx/logs
echo "*********************** copy nginx config ***********************"
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Unconditionally creating /usr/share/nginx/logs may fail if the directory already exists.
Use 'mkdir -p' to prevent errors if the directory already exists during repeated deployments.
```suggestion
mkdir -p /usr/share/nginx/logs
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull Request Overview
Adds initial .NET 10 support across the solution, updates UI copy to reflect NET10, and adjusts build/deploy tooling accordingly.
- Add net10.0 TFM and preview package versions.
- Update CI to use .NET 10 SDK and deployment scripts to publish/copy net10 output.
- Introduce a NotFound page wiring in Router and minor UI/JS tweaks.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BootstrapBlazor/Directory.Build.props | Adds net10.0 target and NET10 preview package version, plus net10-specific PackageReferences. |
| src/BootstrapBlazor.Server/Locales/zh-CN.json | Updates support text to include NET10. |
| src/BootstrapBlazor.Server/Locales/en-US.json | Updates support text to include NET10. |
| src/BootstrapBlazor.Server/Directory.Build.props | Enables HotReloadAutoRestart for server. |
| src/BootstrapBlazor.Server/Components/Samples/Reconnectors.razor | Updates displayed supported frameworks to include NET10. |
| src/BootstrapBlazor.Server/Components/Routes.razor | Configures Router with a NotFoundPage. |
| src/BootstrapBlazor.Server/Components/Pages/NotFound.razor | Adds NotFound page that redirects to root. |
| src/BootstrapBlazor.Server/Components/Pages/Install_wasm.razor | Updates displayed target frameworks to include NET10. |
| src/BootstrapBlazor.Server/Components/Pages/Install_Server.razor | Updates displayed target frameworks to include NET10. |
| src/BootstrapBlazor.Server/Components/Layout/ComponentLayout.razor.js | Adjusts scrollIntoView alignment (center -> start). |
| src/BootstrapBlazor.Server/Components/Components/BlazorReconnector.razor | Updates displayed supported frameworks to include NET10. |
| scripts/linux/deploy.sh | Adds creation of nginx logs directory. |
| scripts/linux/deploy-blazor.sh | Changes copy path from net9.0 to net10.0. |
| scripts/linux/ba.blazor.service | Changes ExecStart to use bare dotnet. |
| Version.props | Sets RunTargetFramework to net10.0. |
| .github/workflows/publish.yml | Switches SDK setup to 10.0.x. |
| .github/workflows/build.yml | Switches SDK setup to 10.0.x. |
| .github/workflows/auto-pull-request-checks.yml | Switches SDK setup to 10.0.x. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6940 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 740 740
Lines 31819 31875 +56
Branches 4469 4469
=========================================
+ Hits 31819 31875 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6939
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce .NET10 support by updating CI/CD pipelines, documentation, and deployment scripts, add a NotFound page for unmatched routes, and refine UI navigation behavior.
New Features:
Enhancements:
Build:
Deployment: