Skip to content

Conversation

@braia123
Copy link
Collaborator

@braia123 braia123 commented Oct 18, 2025

input输入Enter时,如候选项唯一,直接选中
当焦点从AutoFill移出时,如GetDisplayText(Value)对应的内容与input中的内容不符则清空Value和Input显示内容

Link issues

fixes #6948

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add blur validation and auto-selection behavior to AutoFill: clear invalid inputs on blur with a configurable flag, support a blur event callback, and auto-select the only dropdown item when pressing Enter or NumpadEnter.

New Features:

  • Introduce IsClearOnInvalid parameter to clear input and model on blur when the entered text does not match any item
  • Automatically select the sole suggestion on Enter or NumpadEnter key press
  • Invoke OnBlurAsync callback when the component loses focus

Enhancements:

  • Add getInputValue JavaScript interop method
  • Include NumpadEnter in key handling alongside Enter

input输入Enter时,如候选项唯一,直接选中
当焦点从AutoFill移出时,如GetDisplayText(Value)对应的内容与input中的内容不符则清空Value和Input
@bb-auto
Copy link

bb-auto bot commented Oct 18, 2025

Thanks for your PR, @braia123. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 18, 2025

Reviewer's Guide

This PR introduces a blur-based invalid input clearing feature for the AutoFill component, controlled by a new parameter, and enhances the Enter-key logic to auto-select the sole dropdown suggestion.

Sequence diagram for AutoFill blur and invalid input clearing

sequenceDiagram
    participant User
    participant AutoFill
    participant JS
    User->>AutoFill: Blur event (onblur)
    AutoFill->>JS: GetInputValue()
    JS-->>AutoFill: inputValue
    AutoFill->>AutoFill: Compare inputValue with GetDisplayText(Value)
    alt Input invalid
        AutoFill->>JS: setValue (clear input)
        AutoFill->>AutoFill: CurrentValue = default
    end
Loading

Sequence diagram for AutoFill Enter key auto-selection

sequenceDiagram
    participant User
    participant AutoFillJS
    participant AutoFill
    User->>AutoFillJS: Press Enter
    AutoFillJS->>AutoFillJS: Check dropdown items
    alt Only one suggestion
        AutoFillJS->>AutoFillJS: Trigger click on suggestion
        AutoFillJS->>AutoFill: EnterCallback
    else Multiple suggestions
        AutoFillJS->>AutoFillJS: Select active suggestion
        AutoFillJS->>AutoFill: EnterCallback
    end
Loading

Updated class diagram for AutoFill component

classDiagram
    class AutoFill {
        +float RowHeight
        +bool IsClearOnInvalid
        +Task TriggerFilter(string val)
        +Task OnBlur()
        +Task<string> GetInputValue()
    }
Loading

File-Level Changes

Change Details Files
Add optional invalid-input clearing on blur
  • Introduce IsClearOnInvalid parameter to toggle clearing behavior
  • Implement OnBlur method in AutoFill.razor.cs to fetch input value, compare with display text, and clear model/input if mismatched
  • Expose GetInputValue as JSInvokable and add corresponding JS helper function
  • Bind onblur event to OnBlur handler in AutoFill.razor markup
src/BootstrapBlazor/Components/AutoFill/AutoFill.razor.cs
src/BootstrapBlazor/Components/AutoFill/AutoFill.razor
src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js
Auto-select single suggestion on Enter (including NumpadEnter)
  • Extend keydown handler to recognize 'NumpadEnter' alongside 'Enter'
  • Detect when only one dropdown-item is present, trigger its click, invoke EnterCallback, and bypass default behavior
src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang October 18, 2025 11:41
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 18, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@braia123
Copy link
Collaborator Author

@microsoft-github-policy-service agree

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a88529b) to head (0644397).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6947   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          740       740           
  Lines        31875     31875           
  Branches      4469      4469           
=========================================
  Hits         31875     31875           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang
Copy link
Member

@braia123 感谢提交 PR 稍后我邀请你一下您,这样 PR 就不需要 fork 到自己仓库里,直接在我们的仓库里创建 PR 节省好几个步骤

@braia123 braia123 enabled auto-merge (squash) October 18, 2025 13:33
@ArgoZhang ArgoZhang changed the title AutoFill组件变动 feat(AutoFill): auto select when item length equal 1 Oct 19, 2025
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 19, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 19, 2025
@ArgoZhang ArgoZhang disabled auto-merge October 19, 2025 01:25
@ArgoZhang ArgoZhang merged commit 337f129 into dotnetcore:main Oct 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(AutoFill): auto select when item length equal 1

2 participants