-
-
Notifications
You must be signed in to change notification settings - Fork 362
chore(Version): update run target frameworks #6952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the build configuration to dynamically set target frameworks based on Visual Studio version, removing hardcoded framework targets and centralizing version management.
Key Changes:
- Moved
Version.propsimport fromDirectory.Build.targetstoDirectory.Build.props - Replaced hardcoded target frameworks with dynamic
$(RunTargetFrameworks)property - Added Visual Studio version-specific framework configurations in
Version.props
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Directory.Build.targets |
Removed Version.props import that was previously defined here |
Directory.Build.props |
Added Version.props import and replaced hardcoded frameworks with $(RunTargetFrameworks) variable |
Version.props |
Added conditional property groups based on Visual Studio version to define appropriate target frameworks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6952 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 740 740
Lines 31891 31891
Branches 4472 4472
=========================================
Hits 31891 31891
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6951
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update project target frameworks for run configuration across version and build files
Build: