Skip to content

Conversation

@braia123
Copy link
Collaborator

@braia123 braia123 commented Oct 22, 2025

当初始化或选择选项后更新_clientValue

Link issues

fixes #6976

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix AutoFill not updating _clientValue on initialization or selection to keep it in sync with the display text

当初始化或选择选项后更新_clientValue
@bb-auto
Copy link

bb-auto bot commented Oct 22, 2025

Thanks for your PR, @braia123. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Sync _clientValue with the computed display text during component parameter initialization and after selection changes.

Class diagram for updated AutoFill component state management

classDiagram
    class AutoFill {
        - string _displayText
        - string _clientValue
        + OnParametersSet()
    }
    AutoFill : OnParametersSet() updates _displayText
    AutoFill : OnParametersSet() now also updates _clientValue with _displayText
Loading

File-Level Changes

Change Details Files
Ensure client-side value matches the displayed text on initialization or selection
  • Add assignment of _clientValue to _displayText in OnParametersSet
src/BootstrapBlazor/Components/AutoFill/AutoFill.razor.cs

Possibly linked issues

  • #provided_issue: PR correctly initializes AutoFill's _clientValue, stopping infinite OnCustomFilter calls with null searchText.
  • #N/A: The PR updates _clientValue in AutoFill.razor.cs to ensure front-end and back-end values are synchronized, addressing the reported IsClearable bug.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang October 22, 2025 11:14
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 22, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bfcb69c) to head (9269db0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6975   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          741       741           
  Lines        32343     32343           
  Branches      4481      4481           
=========================================
  Hits         32343     32343           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title Update AutoFill.razor.cs refactor(AutoFill): sync client value after server rerender Oct 22, 2025
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 22, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 22, 2025
@ArgoZhang ArgoZhang merged commit 17b2560 into main Oct 22, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the AutoFill branch October 22, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(AutoFill): sync client value after server rerender

3 participants