-
-
Notifications
You must be signed in to change notification settings - Fork 362
refactor(AutoFill): sync client value after server rerender #6975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
当初始化或选择选项后更新_clientValue
|
Thanks for your PR, @braia123. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSync _clientValue with the computed display text during component parameter initialization and after selection changes. Class diagram for updated AutoFill component state managementclassDiagram
class AutoFill {
- string _displayText
- string _clientValue
+ OnParametersSet()
}
AutoFill : OnParametersSet() updates _displayText
AutoFill : OnParametersSet() now also updates _clientValue with _displayText
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6975 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 741 741
Lines 32343 32343
Branches 4481 4481
=========================================
Hits 32343 32343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
当初始化或选择选项后更新_clientValue
Link issues
fixes #6976
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: