-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(EditorForm): parameter LabelWidth not work when set GroupOrder #6984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR fixes the issue where the LabelWidth parameter was ignored when using GroupOrder by ensuring the FormStyleString (which includes label width) is applied directly to each group container. Class diagram for updated EditorForm group renderingclassDiagram
class EditorForm {
- FormClassString: string
- FormStyleString: string
+ RenderGroupItems: RenderFragment<KeyValuePair<string, IOrderedEnumerable<IEditorItem>>>
+ GetRenderTemplate(item: IEditorItem): RenderFragment
}
class GroupBox {
+ Title: string
}
EditorForm "1" -- "*" GroupBox: renders
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where the LabelWidth parameter was not being applied correctly when GroupOrder was set in the EditorForm component. The fix ensures that form styling is properly propagated to grouped items by adding the FormStyleString to the div element inside the GroupBox.
- Added
FormStyleStringto the div element within grouped items rendering
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6984 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 741 741
Lines 32343 32352 +9
Branches 4481 4481
=========================================
+ Hits 32343 32352 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6983
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: