Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 23, 2025

Link issues

fixes #6988

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Extend the GitHub Actions pack workflow by adding a dedicated NET9 job for packaging and publishing .NET 9 artifacts, update triggers to include the 'action' event, and rename the legacy pack job to NET10.

New Features:

  • Add NET9 job in CI to restore, build, pack, and publish .NET 9 package to NuGet

Enhancements:

  • Include 'action' event in pack workflow triggers
  • Rename existing pack job to NET10 to target .NET 10

Copilot AI review requested due to automatic review settings October 23, 2025 03:41
@bb-auto bb-auto bot added the chore This are tasks or bot action label Oct 23, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 23, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 23, 2025

Reviewer's Guide

This PR enhances the GitHub Actions packaging workflow by adding a dedicated .NET 9 pack-and-publish job, updating triggers to include the “action” event, and separating the original pack job into a NET10 job.

Flow diagram for new NET9 pack and publish process

flowchart TD
  A["Start NET9 Job"]
  B["Checkout repository"]
  C["Setup .NET 9 SDK"]
  D["Cache NuGet packages"]
  E["Restore dependencies"]
  F["NuGet login"]
  G["Build project"]
  H["Pack project"]
  I["Push package to NuGet"]

  A --> B --> C --> D --> E --> F --> G --> H --> I
Loading

File-Level Changes

Change Details Files
Expanded workflow triggers to include a new GitHub event
  • Added “action” to the push event triggers
.github/workflows/pack.yml
Introduced a NET9 packaging job
  • Checkout code using actions/checkout
  • Setup .NET 9.0 SDK
  • Cache and restore NuGet packages
  • Authenticate with NuGet and retrieve API key
  • Build, pack, and push NuGet package with skip-duplicate flag
.github/workflows/pack.yml
Renamed existing pack job to NET10
  • Changed job identifier from “pack” to “NET10” to distinguish from new job
.github/workflows/pack.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#6988 Add a GitHub Action to pack the project using .NET 9 (net9).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new .NET 9 pack action to the GitHub workflow for building and publishing NuGet packages. The changes enable the project to support both .NET 9 and .NET 10 build pipelines.

Key Changes:

  • Updated language version to preview to support newer C# features
  • Added new NET9 job to pack workflow for .NET 9.0.x builds
  • Renamed existing pack job to NET10 for clarity

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Directory.Build.props Changed LangVersion from 'latest' to 'preview' to enable preview language features
.github/workflows/pack.yml Added NET9 build job and renamed existing job to NET10; added 'action' branch trigger

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 23, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider consolidating the NET9 and NET10 jobs into a matrix strategy to avoid duplicating the same steps for multiple SDK versions.
  • Rename the job identifiers to follow our standard naming conventions (e.g., lowercase with hyphens) for consistency across workflows.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider consolidating the NET9 and NET10 jobs into a matrix strategy to avoid duplicating the same steps for multiple SDK versions.
- Rename the job identifiers to follow our standard naming conventions (e.g., lowercase with hyphens) for consistency across workflows.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit d28cda3 into main Oct 23, 2025
4 of 5 checks passed
@ArgoZhang ArgoZhang deleted the action branch October 23, 2025 03:42
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (58180ef) to head (49903a3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6989   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          741       741           
  Lines        32365     32365           
  Branches      4481      4481           
=========================================
  Hits         32365     32365           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Action): add net9 pack action

2 participants