-
-
Notifications
You must be signed in to change notification settings - Fork 362
chore(Action): add net9 pack action #6989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR enhances the GitHub Actions packaging workflow by adding a dedicated .NET 9 pack-and-publish job, updating triggers to include the “action” event, and separating the original pack job into a NET10 job. Flow diagram for new NET9 pack and publish processflowchart TD
A["Start NET9 Job"]
B["Checkout repository"]
C["Setup .NET 9 SDK"]
D["Cache NuGet packages"]
E["Restore dependencies"]
F["NuGet login"]
G["Build project"]
H["Pack project"]
I["Push package to NuGet"]
A --> B --> C --> D --> E --> F --> G --> H --> I
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new .NET 9 pack action to the GitHub workflow for building and publishing NuGet packages. The changes enable the project to support both .NET 9 and .NET 10 build pipelines.
Key Changes:
- Updated language version to preview to support newer C# features
- Added new NET9 job to pack workflow for .NET 9.0.x builds
- Renamed existing pack job to NET10 for clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Directory.Build.props | Changed LangVersion from 'latest' to 'preview' to enable preview language features |
| .github/workflows/pack.yml | Added NET9 build job and renamed existing job to NET10; added 'action' branch trigger |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider consolidating the NET9 and NET10 jobs into a matrix strategy to avoid duplicating the same steps for multiple SDK versions.
- Rename the job identifiers to follow our standard naming conventions (e.g., lowercase with hyphens) for consistency across workflows.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider consolidating the NET9 and NET10 jobs into a matrix strategy to avoid duplicating the same steps for multiple SDK versions.
- Rename the job identifiers to follow our standard naming conventions (e.g., lowercase with hyphens) for consistency across workflows.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6989 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 741 741
Lines 32365 32365
Branches 4481 4481
=========================================
Hits 32365 32365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6988
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Extend the GitHub Actions pack workflow by adding a dedicated NET9 job for packaging and publishing .NET 9 artifacts, update triggers to include the 'action' event, and rename the legacy pack job to NET10.
New Features:
Enhancements: