-
-
Notifications
You must be signed in to change notification settings - Fork 362
chore(Action): update pack action #6991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR streamlines the GitHub Actions pack workflow by consolidating separate .NET jobs into a unified pack job, adding multi-VisualStudioVersion packing with cleanup, integrating NuGet push steps, and introducing a refactor-action trigger. Flow diagram for unified pack job stepsflowchart TD
A[Checkout repository]
B[Setup .NET Core SDK]
C[Cache NuGet packages]
D[Restore dependencies]
E[NuGet login]
F[Build project]
G[Pack with VisualStudioVersion 17.0]
H[Push NuGet package 17.0]
I[Cleanup published artifacts]
J[Pack with VisualStudioVersion 18.0]
K[Push NuGet package 18.0]
A --> B --> C --> D --> E --> F --> G --> H --> I --> J --> K
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the pack GitHub Action workflow to consolidate the build and publish process. It removes the dual .NET 9 and .NET 10 job structure and replaces it with a single job that builds packages for both Visual Studio 17.0 and 18.0 versions. Additionally, the C# language version is changed from preview to latest, and a configuration file is added to the solution explorer.
Key changes:
- Consolidated two separate jobs (NET9 and NET10) into a single
packjob - Modified the pack workflow to create and publish two package versions using different VisualStudioVersion properties
- Changed LangVersion from "preview" to "latest" in Directory.Build.props
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Directory.Build.props | Updated C# language version from preview to latest |
| BootstrapBlazor.slnx | Added Directory.Build.props to the solution configuration folder |
| .github/workflows/pack.yml | Consolidated NET9 and NET10 jobs into single pack job with dual-version build support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6991 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 741 741
Lines 32365 32365
Branches 4481 4481
=========================================
Hits 32365 32365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6990
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Merge .NET 9 and .NET 10 packaging jobs into a single 'pack' workflow job, introduce VisualStudioVersion parameters for dual-version packaging, and clean up artifacts between packaging steps.
Enhancements: