Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 23, 2025

Link issues

fixes #6990

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Merge .NET 9 and .NET 10 packaging jobs into a single 'pack' workflow job, introduce VisualStudioVersion parameters for dual-version packaging, and clean up artifacts between packaging steps.

Enhancements:

  • Consolidate separate NET9 and NET10 jobs into one 'pack' job in the GitHub Actions workflow
  • Add VisualStudioVersion property to dotnet pack commands for 17.0 and 18.0 and push both package outputs
  • Remove existing nupkg files between packaging runs to avoid conflicts

Copilot AI review requested due to automatic review settings October 23, 2025 05:03
@bb-auto bb-auto bot added the chore This are tasks or bot action label Oct 23, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 23, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR streamlines the GitHub Actions pack workflow by consolidating separate .NET jobs into a unified pack job, adding multi-VisualStudioVersion packing with cleanup, integrating NuGet push steps, and introducing a refactor-action trigger.

Flow diagram for unified pack job steps

flowchart TD
  A[Checkout repository]
  B[Setup .NET Core SDK]
  C[Cache NuGet packages]
  D[Restore dependencies]
  E[NuGet login]
  F[Build project]
  G[Pack with VisualStudioVersion 17.0]
  H[Push NuGet package 17.0]
  I[Cleanup published artifacts]
  J[Pack with VisualStudioVersion 18.0]
  K[Push NuGet package 18.0]

  A --> B --> C --> D --> E --> F --> G --> H --> I --> J --> K
Loading

File-Level Changes

Change Details Files
Consolidate .NET pack jobs into a single workflow job
  • Remove separate NET9 job
  • Remove separate NET10 job
  • Define new 'pack' job
.github/workflows/pack.yml
Enable packing for multiple VisualStudio versions and clean up artifacts
  • Pack with VisualStudioVersion 17.0
  • Pack with VisualStudioVersion 18.0
  • Remove .nupkg files after push
.github/workflows/pack.yml
Embed NuGet push within the pack job
  • Include dotnet nuget push steps for each pack
  • Eliminate duplicate push commands
.github/workflows/pack.yml
Extend workflow triggers
  • Add 'refactor-action' trigger alongside release and hotfix
.github/workflows/pack.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#6990 Update the pack action workflow to consolidate .NET jobs and streamline packing and publishing processes.
#6990 Add support for packing with VisualStudioVersion 17.0 and 18.0, including cleanup of published artifacts.
#6990 Include dotnet nuget push steps within the pack job and remove duplicate package files.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the pack GitHub Action workflow to consolidate the build and publish process. It removes the dual .NET 9 and .NET 10 job structure and replaces it with a single job that builds packages for both Visual Studio 17.0 and 18.0 versions. Additionally, the C# language version is changed from preview to latest, and a configuration file is added to the solution explorer.

Key changes:

  • Consolidated two separate jobs (NET9 and NET10) into a single pack job
  • Modified the pack workflow to create and publish two package versions using different VisualStudioVersion properties
  • Changed LangVersion from "preview" to "latest" in Directory.Build.props

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Directory.Build.props Updated C# language version from preview to latest
BootstrapBlazor.slnx Added Directory.Build.props to the solution configuration folder
.github/workflows/pack.yml Consolidated NET9 and NET10 jobs into single pack job with dual-version build support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang merged commit f2de6f4 into main Oct 23, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-action branch October 23, 2025 05:04
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d28cda3) to head (b80e292).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6991   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          741       741           
  Lines        32365     32365           
  Branches      4481      4481           
=========================================
  Hits         32365     32365           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Action): update pack action

2 participants