revert(Table): restore editing when enable virtualize #6993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR restores add and edit functionality for tables with virtualization enabled by removing ScrollMode-based restrictions on toolbar and inline edit buttons. Class diagram for updated Table toolbar button logicclassDiagram
class Table {
+ShowAddButton
+ShowEditButton
+ScrollMode
+IsExcel
+AddAsync()
+EditAsync()
+GetAddButtonStatus()
+GetEditButtonStatus()
}
class TableToolbarButton {
+TItem
+Color
+OnClick
+Icon
+Text
+IsDisabled
+IsEnableWhenSelectedOneRow
}
Table --> TableToolbarButton : uses
class TableToolbar {
+GetShowExtendEditButton(TItem)
+ShowExtendEditButtonCallback
+ShowExtendEditButton
+ScrollMode
}
TableToolbar : GetShowExtendEditButton(TItem)
TableToolbar --> Table : accesses ShowExtendEditButtonCallback, ShowExtendEditButton
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR restores the ability to use inline editing functionality in tables when virtualization is enabled. Previously, editing buttons were hidden when ScrollMode.Virtual was active, which unnecessarily restricted functionality.
Key Changes:
- Removed the
ScrollMode != ScrollMode.Virtualcondition that was blocking inline editing in virtual scroll mode - Removed
ScrollMode == ScrollMode.Nonechecks that were preventing Add and Edit toolbar buttons from appearing in virtualized tables
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs | Removed ScrollMode condition from GetShowExtendEditButton method to allow inline edit buttons in virtual scroll mode |
| src/BootstrapBlazor/Components/Table/Table.razor | Removed ScrollMode restrictions from ShowAddButton and ShowEditButton toolbar button visibility logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- With virtualization re-enabled for editing, ensure that editing a virtualized row properly scrolls it into view or renders it before activating edit mode to prevent UI glitches.
- Double-check that removing the ScrollMode guard on GetShowExtendEditButton doesn't introduce inline-edit buttons for items outside the rendered viewport without proper focus or event handling.
- Review focus and selection management for add/edit operations under virtualize mode to ensure the correct row remains selected and editable after virtualization refresh.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- With virtualization re-enabled for editing, ensure that editing a virtualized row properly scrolls it into view or renders it before activating edit mode to prevent UI glitches.
- Double-check that removing the ScrollMode guard on GetShowExtendEditButton doesn't introduce inline-edit buttons for items outside the rendered viewport without proper focus or event handling.
- Review focus and selection management for add/edit operations under virtualize mode to ensure the correct row remains selected and editable after virtualization refresh.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/Table/Table.razor:54` </location>
<code_context>
{
<TableToolbarButton TItem="TItem" Color="Color.Success" OnClick="AddAsync" Icon="@AddButtonIcon" Text="@AddButtonText" IsDisabled="GetAddButtonStatus()" />
}
- @if (!IsExcel && ShowEditButton && ScrollMode == ScrollMode.None)
+ @if (!IsExcel && ShowEditButton)
{
<TableToolbarButton TItem="TItem" IsDisabled="GetEditButtonStatus()" Color="Color.Primary" OnClick="EditAsync" Icon="@EditButtonIcon" Text="@EditButtonText" IsEnableWhenSelectedOneRow="true" />
</code_context>
<issue_to_address>
**issue (bug_risk):** Edit button visibility is now independent of ScrollMode, which may affect edit functionality.
Please confirm that editing works correctly in all scroll modes now that the button is always visible.
</issue_to_address>
### Comment 2
<location> `src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs:1226` </location>
<code_context>
/// 是否显示行内编辑按钮
/// </summary>
/// <returns></returns>
- protected bool GetShowExtendEditButton(TItem item) => ScrollMode != ScrollMode.Virtual && (ShowExtendEditButtonCallback?.Invoke(item) ?? ShowExtendEditButton);
+ protected bool GetShowExtendEditButton(TItem item) => ShowExtendEditButtonCallback?.Invoke(item) ?? ShowExtendEditButton;
/// <summary>
</code_context>
<issue_to_address>
**issue (bug_risk):** The removal of the ScrollMode check for the extended edit button may allow editing in virtual scroll mode.
If editing in virtual scroll mode is not fully supported, consider restoring the restriction or adding appropriate safeguards.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6993 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 741 741
Lines 32365 32365
Branches 4481 4481
=========================================
Hits 32365 32365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6992
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Restore Table editing when virtual scrolling is enabled by removing ScrollMode restrictions on toolbar and inline edit buttons.
Bug Fixes: