Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 24, 2025

Link issues

fixes #7000

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bump the package version to 9.0.4 and enhance the SortableList sample with an OnAddClone handler that clones items during drag-and-drop operations

Enhancements:

  • Add OnAddClone event handler and markup in SortableList sample to clone items when dragging between lists

Build:

  • Bump BootstrapBlazor.Server package version to 9.0.4

Copilot AI review requested due to automatic review settings October 24, 2025 15:21
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 24, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 24, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request enhances the SortableList sample by adding a clone-on-add feature and wires it up in the Razor component, as well as bumps the package version to 9.0.4.

Sequence diagram for the new clone-on-add interaction in SortableList

sequenceDiagram
    participant User
    participant SortableList
    participant SortableLists.razor.cs
    participant ItemsCloneLeft
    participant ItemsCloneRight
    User->>SortableList: Drag item from left list
    SortableList->>SortableLists.razor.cs: Trigger OnAddClone(@event)
    SortableLists.razor.cs->>ItemsCloneLeft: Get item at @event.OldIndex
    SortableLists.razor.cs->>ItemsCloneRight: Insert new Foo(Name) at @event.NewIndex
    SortableLists.razor.cs-->>SortableList: Task.CompletedTask
    SortableList-->>User: Update right list with cloned item
Loading

Class diagram for updated SortableLists.razor.cs with OnAddClone method

classDiagram
    class SortableLists {
        +Task OnAddClone(SortableEvent @event)
        ItemsCloneLeft : List<Foo>
        ItemsCloneRight : List<Foo>
    }
    class Foo {
        +string Name
    }
    class SortableEvent {
        +int OldIndex
        +int NewIndex
    }
    SortableLists --> SortableEvent
    SortableLists --> Foo
Loading

Flow diagram for clone-on-add logic in SortableLists.razor.cs

flowchart TD
    A[User drags item from left list] --> B[OnAddClone triggered]
    B --> C[Get item from ItemsCloneLeft at OldIndex]
    C --> D[Create new Foo with Name]
    D --> E[Insert new Foo into ItemsCloneRight at NewIndex]
    E --> F[Update UI to show cloned item]
Loading

File-Level Changes

Change Details Files
Introduce clone-on-add handler for sortable lists
  • Added OnAddClone method signature
  • Retrieve item from source list by OldIndex
  • Insert a new Foo instance into target list at NewIndex
  • Return completed task
src/BootstrapBlazor.Server/Components/Samples/SortableLists.razor.cs
Wire up OnAddClone in the Razor component
  • Added OnAdd="OnAddClone" attribute to SortableList
  • Ensured ItemsCloneRight is used in the list rendering
src/BootstrapBlazor.Server/Components/Samples/SortableLists.razor
Bump BootstrapBlazor.Server package version to 9.0.4
  • Updated Version element in csproj
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#7000 Fix the bug where using clone mode in SortableList generates two items instead of one.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 7f58aa9 into main Oct 24, 2025
4 of 5 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the BootstrapBlazor.Sortable package from version 9.0.3 to 9.0.4 and implements a clone functionality for sortable lists. The changes add an event handler to properly manage item cloning when dragging items between sortable lists.

  • Added OnAddClone event handler to handle cloning items between sortable lists
  • Updated the SortableList component to wire up the new event handler
  • Bumped BootstrapBlazor.Sortable package version to 9.0.4

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
SortableLists.razor.cs Adds OnAddClone method to handle cloning items from left list to right list
SortableLists.razor Connects the OnAdd event to the new OnAddClone handler for the clone list
BootstrapBlazor.Server.csproj Updates BootstrapBlazor.Sortable package reference from 9.0.3 to 9.0.4

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang deleted the feat-sortable branch October 24, 2025 15:21
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (37ab016) to head (632c6d1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7001   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          741       741           
  Lines        32397     32397           
  Branches      4485      4485           
=========================================
  Hits         32397     32397           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(SortableList): bump version 9.0.4

2 participants