-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(SortableList): bump version 9.0.4 #7001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis pull request enhances the SortableList sample by adding a clone-on-add feature and wires it up in the Razor component, as well as bumps the package version to 9.0.4. Sequence diagram for the new clone-on-add interaction in SortableListsequenceDiagram
participant User
participant SortableList
participant SortableLists.razor.cs
participant ItemsCloneLeft
participant ItemsCloneRight
User->>SortableList: Drag item from left list
SortableList->>SortableLists.razor.cs: Trigger OnAddClone(@event)
SortableLists.razor.cs->>ItemsCloneLeft: Get item at @event.OldIndex
SortableLists.razor.cs->>ItemsCloneRight: Insert new Foo(Name) at @event.NewIndex
SortableLists.razor.cs-->>SortableList: Task.CompletedTask
SortableList-->>User: Update right list with cloned item
Class diagram for updated SortableLists.razor.cs with OnAddClone methodclassDiagram
class SortableLists {
+Task OnAddClone(SortableEvent @event)
ItemsCloneLeft : List<Foo>
ItemsCloneRight : List<Foo>
}
class Foo {
+string Name
}
class SortableEvent {
+int OldIndex
+int NewIndex
}
SortableLists --> SortableEvent
SortableLists --> Foo
Flow diagram for clone-on-add logic in SortableLists.razor.csflowchart TD
A[User drags item from left list] --> B[OnAddClone triggered]
B --> C[Get item from ItemsCloneLeft at OldIndex]
C --> D[Create new Foo with Name]
D --> E[Insert new Foo into ItemsCloneRight at NewIndex]
E --> F[Update UI to show cloned item]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the BootstrapBlazor.Sortable package from version 9.0.3 to 9.0.4 and implements a clone functionality for sortable lists. The changes add an event handler to properly manage item cloning when dragging items between sortable lists.
- Added
OnAddCloneevent handler to handle cloning items between sortable lists - Updated the SortableList component to wire up the new event handler
- Bumped BootstrapBlazor.Sortable package version to 9.0.4
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SortableLists.razor.cs | Adds OnAddClone method to handle cloning items from left list to right list |
| SortableLists.razor | Connects the OnAdd event to the new OnAddClone handler for the clone list |
| BootstrapBlazor.Server.csproj | Updates BootstrapBlazor.Sortable package reference from 9.0.3 to 9.0.4 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7001 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 741 741
Lines 32397 32397
Branches 4485 4485
=========================================
Hits 32397 32397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7000
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bump the package version to 9.0.4 and enhance the SortableList sample with an OnAddClone handler that clones items during drag-and-drop operations
Enhancements:
Build: