Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 29, 2025

Link issues

fixes #7020

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add OnCloseTabItemAsync callback to Layout component and bind it to the Tab component to enable async pre-close logic and optional cancellation of tab items

New Features:

  • Add OnCloseTabItemAsync parameter to the Layout component to support async interception and cancellation of tab close events

Bug Fixes:

Enhancements:

  • Wire the new OnCloseTabItemAsync parameter through to the underlying Tab component

Copilot AI review requested due to automatic review settings October 29, 2025 04:42
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 29, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 29, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances the Layout component by introducing an asynchronous OnCloseTabItemAsync callback to intercept and optionally cancel tab closures, and wires it through to the razor template.

Sequence diagram for tab close interception with OnCloseTabItemAsync

sequenceDiagram
    participant User
    participant Layout
    participant TabItem
    User->>Layout: Request to close TabItem
    Layout->>Layout: Invoke OnCloseTabItemAsync(TabItem)
    alt OnCloseTabItemAsync returns true
        Layout->>TabItem: Close TabItem
    else OnCloseTabItemAsync returns false
        Layout-->>User: Tab closure cancelled
    end
Loading

Class diagram for updated Layout component with OnCloseTabItemAsync

classDiagram
    class Layout {
        +Func<Task>? OnToolbarRefreshCallback
        +Func<TabItem, Task<bool>>? OnCloseTabItemAsync
    }
    class TabItem
    Layout --> TabItem : uses in OnCloseTabItemAsync
Loading

File-Level Changes

Change Details Files
Introduce asynchronous close tab callback parameter
  • Declare new OnCloseTabItemAsync Func<TabItem, Task> parameter
  • Add XML doc comment explaining return false cancels tab closure
src/BootstrapBlazor/Components/Layout/Layout.razor.cs
Wire new callback into razor template
  • Include OnCloseTabItemAsync binding on the Tab component invocation
src/BootstrapBlazor/Components/Layout/Layout.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#7020 Add an OnCloseTabItemAsync parameter to the Layout component to allow users to specify a callback for tab close events.
#7020 Ensure the new OnCloseTabItemAsync parameter is documented or its usage is clear to users. The PR does not include any documentation updates or usage examples for the new parameter, which was specifically requested in the issue for clarity.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 29, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f131098) to head (e9ea07a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7023   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        32452     32453    +1     
  Branches      4498      4498           
=========================================
+ Hits         32452     32453    +1     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a callback method to control tab closing behavior in the Layout component. The callback allows consumers to implement custom logic that can prevent a tab from being closed by returning false.

  • Added OnCloseTabItemAsync parameter to the Layout component that accepts a callback function
  • Passed the new parameter through to the underlying Tab component which already supports this functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/BootstrapBlazor/Components/Layout/Layout.razor.cs Added the OnCloseTabItemAsync parameter with documentation describing the callback behavior
src/BootstrapBlazor/Components/Layout/Layout.razor Passed the new OnCloseTabItemAsync parameter to the Tab component

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ArgoZhang ArgoZhang merged commit c132947 into main Oct 29, 2025
3 of 5 checks passed
@ArgoZhang ArgoZhang deleted the feat-tab branch October 29, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Layout): add OnCloseTabItemAsync parameter

2 participants