Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 29, 2025

Link issues

fixes #7024

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Adjust CardUpload component to apply custom IconTemplate before default image preview and update unit tests to cover null template and JSON deserialization

Bug Fixes:

  • Swap rendering conditions in CardUpload to prioritize IconTemplate over image preview

Tests:

  • Add explicit null IconTemplate parameter in UploadCard unit test
  • Include NotNull assertion for deserialized ColumnVisibleItem in JSON converter test

Copilot AI review requested due to automatic review settings October 29, 2025 09:46
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 29, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 29, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts the rendering logic in CardUpload so that a custom IconTemplate is displayed before the default image preview, and updates associated unit tests to reflect this change and strengthen JSON converter testing.

Class diagram for CardUpload rendering logic update

classDiagram
    class CardUpload {
        +AllowExtensions
        +CanPreviewCallback
        +IconTemplate
        +GetItemClassString(item)
        +OnClickZoom(item)
    }
    class UploadItem {
        +PrevUrl
        +IsImage(allowExtensions, canPreviewCallback)
    }
    CardUpload "1" *-- "many" UploadItem: contains
    CardUpload : IconTemplate(item)
    UploadItem : IsImage(AllowExtensions, CanPreviewCallback)
    CardUpload : OnClickZoom(item)
    CardUpload : GetItemClassString(item)
Loading

File-Level Changes

Change Details Files
Prioritize IconTemplate over image preview in upload item rendering
  • Swapped conditions to check IconTemplate first
  • Changed else-if to evaluate image preview via IsImage
  • Updated markup accordingly
src/BootstrapBlazor/Components/Upload/CardUpload.razor
Updated CardUpload unit test to explicitly set IconTemplate to null
  • Added parameter binding for IconTemplate as null
test/UnitTest/Components/UploadCardTest.cs
Added null check assertion in JSON enum converter test
  • Inserted Assert.NotNull for deserialized object before property checks
test/UnitTest/Converters/JsonDescriptionEnumConverterTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#7024 Adjust the order of IconTemplate and image rendering logic in CardUpload component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit d82ddbe into main Oct 29, 2025
8 of 9 checks passed
@ArgoZhang ArgoZhang deleted the feat-cardupload branch October 29, 2025 09:46
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c132947) to head (ba31a1d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7025   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        32453     32453           
  Branches      4498      4498           
=========================================
  Hits         32453     32453           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modifies the CardUpload component to prioritize the IconTemplate rendering over the default image preview logic, and adds corresponding test coverage for this behavior change.

  • Changed the conditional rendering order in CardUpload.razor to check IconTemplate first
  • Added test to verify IconTemplate can be reset to null
  • Added null assertion to improve test robustness in JsonDescriptionEnumConverterTest

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor/Components/Upload/CardUpload.razor Reordered conditional checks to prioritize custom IconTemplate over default image rendering
test/UnitTest/Components/UploadCardTest.cs Added test case to verify IconTemplate can be explicitly set to null
test/UnitTest/Converters/JsonDescriptionEnumConverterTest.cs Added null assertion for deserialized object before accessing properties

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(CardUpload): adjust IconTemplate order

2 participants