feat(CardUpload): add BeforeActionButtonTemplate parameter #7030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR introduces a BeforeActionButtonTemplate parameter to the CardUpload component, updates its rendering logic to display this template before existing action buttons, and extends unit tests to cover the new feature. Class diagram for updated CardUpload componentclassDiagram
class CardUpload {
+RenderFragment<UploadFile>? IconTemplate
+RenderFragment<UploadFile>? BeforeActionButtonTemplate
+RenderFragment<UploadFile>? ActionButtonTemplate
}
CardUpload <|-- UploadFile
Flow diagram for CardUpload action button rendering logic updateflowchart TD
A["Check BeforeActionButtonTemplate"] -->|If not null| B["Render BeforeActionButtonTemplate(item)"]
B --> C["Check ShowZoomButton"]
C -->|If true| D["Render Zoom Button"]
D --> E["Check ShowCancelButton"]
C -->|If false| E
E -->|If true| F["Render Cancel Button"]
F --> G["Check ActionButtonTemplate"]
E -->|If false| G
G -->|If not null| H["Render ActionButtonTemplate(item)"]
H --> I["Check ShowDeleteButton"]
G -->|If null| I
I -->|If true| J["Render Delete Button"]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `test/UnitTest/Components/UploadCardTest.cs:232` </location>
<code_context>
[
new() { FileName = "test.png" }
]);
+ pb.Add(a => a.BeforeActionButtonTemplate, file => pb =>
+ {
+ pb.AddMarkupContent(0, "<button class=\"before-action-button-test\"></button>");
</code_context>
<issue_to_address>
**suggestion (testing):** Consider adding tests for edge cases with BeforeActionButtonTemplate.
Please add tests for cases where BeforeActionButtonTemplate is null and when it renders more complex content to ensure all scenarios are covered.
</issue_to_address>
### Comment 2
<location> `test/UnitTest/Components/UploadCardTest.cs:242-243` </location>
<code_context>
});
});
+ cut.Contains("before-action-button-test");
cut.Contains("action-button-test");
}
</code_context>
<issue_to_address>
**suggestion (testing):** Use more specific assertions for rendered content.
Instead of 'cut.Contains', use assertions that verify the presence of the button by its class or tag to improve test reliability and reduce false positives.
```suggestion
// Assert that a button with the expected class exists
Assert.NotNull(cut.Find("button.before-action-button-test"));
Assert.NotNull(cut.Find("button.action-button-test"));
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7030 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 743 743
Lines 32458 32463 +5
Branches 4499 4500 +1
=========================================
+ Hits 32458 32463 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new BeforeActionButtonTemplate parameter to the CardUpload component, allowing users to render custom buttons before the existing action buttons (zoom, download, cancel). The existing ActionButtonTemplate is repositioned to render after these built-in buttons.
Key changes:
- Added new
BeforeActionButtonTemplateparameter to allow custom action buttons before built-in buttons - Moved existing
ActionButtonTemplateto render after built-in action buttons for better positioning - Added test coverage for both templates
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/BootstrapBlazor/Components/Upload/CardUpload.razor.cs | Added BeforeActionButtonTemplate parameter with documentation |
| src/BootstrapBlazor/Components/Upload/CardUpload.razor | Repositioned template rendering logic to place custom templates before and after built-in action buttons |
| test/UnitTest/Components/UploadCardTest.cs | Added test coverage for both BeforeActionButtonTemplate and ActionButtonTemplate |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+57
to
+60
| @if (ActionButtonTemplate != null) | ||
| { | ||
| @ActionButtonTemplate(item) | ||
| } |
There was a problem hiding this comment.
Inconsistent indentation detected. Lines 57-60 use tabs instead of spaces, while the rest of the file uses spaces for indentation. Convert tabs to spaces to match the file's indentation style.
Suggested change
| @if (ActionButtonTemplate != null) | |
| { | |
| @ActionButtonTemplate(item) | |
| } | |
| @if (ActionButtonTemplate != null) | |
| { | |
| @ActionButtonTemplate(item) | |
| } |
| public RenderFragment<UploadFile>? IconTemplate { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// 获得/设置 操作按钮模板 |
There was a problem hiding this comment.
The documentation comment for BeforeActionButtonTemplate is identical to ActionButtonTemplate (line 70). Update the comment to clarify that this template renders action buttons before the built-in buttons, e.g., '获得/设置 操作按钮前置模板' or '获得/设置 在内置操作按钮之前渲染的操作按钮模板'.
Suggested change
| /// 获得/设置 操作按钮模板 | |
| /// 获得/设置 在内置操作按钮之前渲染的操作按钮模板 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7029
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Support custom pre-action buttons in the CardUpload component by introducing BeforeActionButtonTemplate, adjusting its rendering order, and adding corresponding unit tests
New Features:
Enhancements:
Tests: