Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 30, 2025

Link issues

fixes #7033

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Append ImagePreviewer elements to document.body to prevent them from being blocked and ensure they are removed on disposal

Bug Fixes:

  • Append the previewer container to document.body in init to avoid it being blocked by other elements

Enhancements:

  • Remove the previewer element from the DOM on dispose to clean up after use

Copilot AI review requested due to automatic review settings October 30, 2025 05:03
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 30, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 30, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Append the ImagePreviewer container to document.body on initialization to prevent blocking issues and ensure proper teardown by removing it on dispose, alongside adding missing semicolons for consistent code formatting.

Sequence diagram for ImagePreviewer initialization and disposal

sequenceDiagram
participant JS as "ImagePreviewer.razor.js"
participant DOM as "document.body"
participant Data as "Data store"
participant Viewer as "Viewer module"

JS->>DOM: getElementById(id)
alt Element exists
    JS->>Viewer: Viewer.init(el, prevList, config)
    JS->>Data: Data.set(id, viewer)
    JS->>DOM: appendChild(el)
end

Note over JS,DOM: On dispose
JS->>Data: Data.get(id)
JS->>Data: Data.remove(id)
alt viewer exists
    JS->>Viewer: Viewer.dispose(viewer.viewer)
    JS->>DOM: viewer.el.remove()
end
Loading

File-Level Changes

Change Details Files
Move preview element to body and remove on dispose
  • Appended preview element (el) to document.body in init
  • Removed preview element (viewer.el) in dispose after disposing the Viewer instance
src/BootstrapBlazor/Components/ImagePreviewer/ImagePreviewer.razor.js
Add missing semicolons for consistent formatting
  • Added semicolons after const declarations and return statements
  • Terminated Data.set and Viewer.dispose calls with semicolons
  • Adjusted object literal closures to include semicolons
src/BootstrapBlazor/Components/ImagePreviewer/ImagePreviewer.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#7033 Move the ImagePreviewer element to the end of the document body to prevent it from being blocked.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang enabled auto-merge (squash) October 30, 2025 05:03
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds DOM manipulation and improves code consistency in the ImagePreviewer component by adding semicolons and implementing proper element lifecycle management.

Key Changes:

  • Added semicolons for JavaScript best practices consistency
  • Implemented element appending to document body during initialization
  • Added element removal from DOM during disposal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4a6cd16) to head (ac1a5f7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7034   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       743           
  Lines        32470     32470           
  Branches      4500      4500           
=========================================
  Hits         32470     32470           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit a55507d into main Oct 30, 2025
13 checks passed
@ArgoZhang ArgoZhang deleted the feat-preview branch October 30, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ImagePreviewer): move the body end prevent blocked

2 participants