Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 2, 2025

Link issues

fixes #7051

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove rigid table-layout styling from fixed columns and update the sample template column to use the ReadonlyColumn property

Bug Fixes:

Enhancements:

  • Remove the table-layout: fixed style for fixed columns to allow flexible column widths
  • Update the sample TableEdit component to display the ReadonlyColumn value in the template column

Copilot AI review requested due to automatic review settings November 2, 2025 09:55
@bb-auto bb-auto bot added the enhancement New feature or request label Nov 2, 2025
@bb-auto bb-auto bot added this to the 10.0.0 milestone Nov 2, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the fixed-column styling by removing the rigid table-layout definition and revises the sample Table component to render a dynamic readonly column value.

Class diagram for updated Table sample rendering

classDiagram
    class TableColumn {
        +Field
        +Items
        +Ignore
    }
    class TableTemplateColumn {
        +Text
        +Template
    }
    class Context {
        +Hobby
        +Row
    }
    class Row {
        +ReadonlyColumn
    }
    TableColumn <|-- TableTemplateColumn
    Context o-- Row
    TableTemplateColumn --> "Template(Context v)" Context
    Row : ReadonlyColumn
Loading

Flow diagram for Table fixed-column style update

flowchart TD
    A[".table-fixed-column .table"] -- removed --> B["table-layout: fixed;"]
    A -- remains --> C["border-collapse: separate;"]
    A -- remains --> D["border-spacing: 0;"]
Loading

File-Level Changes

Change Details Files
Removed fixed layout CSS for fixed-column tables
  • Deleted the table-layout: fixed property
  • Retained border-collapse and border-spacing settings
Table.razor.scss
Updated sample TablesEdit.razor to bind readonly column value
  • Replaced static “Test” text with @v.Row.ReadonlyColumn
  • Adjusted TableTemplateColumn template syntax
TablesEdit.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#7051 Remove the 'table-layout: fixed' style from tables with fixed columns in the Table component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang enabled auto-merge (squash) November 2, 2025 09:55
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 2, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to be a patch release (version 9.12.1-beta01 and 10.0.0-rc.2.2.1) that fixes a CSS layout issue and corrects a demo example.

  • Removes table-layout: fixed from the fixed-column table CSS to allow more flexible column sizing
  • Updates version numbers for both Visual Studio 17.0 and 18.0 targets
  • Corrects the TableTemplateColumn demo to display actual data instead of placeholder text

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/BootstrapBlazor/Components/Table/Table.razor.scss Removes table-layout: fixed CSS property to fix column layout behavior
src/BootstrapBlazor/BootstrapBlazor.csproj Bumps version numbers to 9.12.1-beta01 and 10.0.0-rc.2.2.1
src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor Updates TableTemplateColumn demo to display ReadonlyColumn data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (841ccab) to head (6d36f4e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7052   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        32532     32532           
  Branches      4510      4510           
=========================================
  Hits         32532     32532           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang disabled auto-merge November 2, 2025 09:58
@ArgoZhang ArgoZhang merged commit d443952 into main Nov 2, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the feat-table branch November 2, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): remove table-layout style when fix column

2 participants