-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Table): remove table-layout style when fix column #7052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refactors the fixed-column styling by removing the rigid table-layout definition and revises the sample Table component to render a dynamic readonly column value. Class diagram for updated Table sample renderingclassDiagram
class TableColumn {
+Field
+Items
+Ignore
}
class TableTemplateColumn {
+Text
+Template
}
class Context {
+Hobby
+Row
}
class Row {
+ReadonlyColumn
}
TableColumn <|-- TableTemplateColumn
Context o-- Row
TableTemplateColumn --> "Template(Context v)" Context
Row : ReadonlyColumn
Flow diagram for Table fixed-column style updateflowchart TD
A[".table-fixed-column .table"] -- removed --> B["table-layout: fixed;"]
A -- remains --> C["border-collapse: separate;"]
A -- remains --> D["border-spacing: 0;"]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR appears to be a patch release (version 9.12.1-beta01 and 10.0.0-rc.2.2.1) that fixes a CSS layout issue and corrects a demo example.
- Removes
table-layout: fixedfrom the fixed-column table CSS to allow more flexible column sizing - Updates version numbers for both Visual Studio 17.0 and 18.0 targets
- Corrects the TableTemplateColumn demo to display actual data instead of placeholder text
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/BootstrapBlazor/Components/Table/Table.razor.scss | Removes table-layout: fixed CSS property to fix column layout behavior |
| src/BootstrapBlazor/BootstrapBlazor.csproj | Bumps version numbers to 9.12.1-beta01 and 10.0.0-rc.2.2.1 |
| src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor | Updates TableTemplateColumn demo to display ReadonlyColumn data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7052 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 32532 32532
Branches 4510 4510
=========================================
Hits 32532 32532
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7051
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove rigid table-layout styling from fixed columns and update the sample template column to use the ReadonlyColumn property
Bug Fixes:
Enhancements: