Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 4, 2025

Link issues

fixes #7059

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Revert ImagePreviewer behavior that moved its DOM element to the end of document.body and manually removed it on dispose to restore original placement and fix issue #7059.

Bug Fixes:

  • Remove document.body.appendChild(el) call to prevent moving the preview element into the body
  • Remove viewer.el.remove() call to avoid manual removal of the preview element on dispose

Copilot AI review requested due to automatic review settings November 4, 2025 00:23
@bb-auto bb-auto bot added the chore This are tasks or bot action label Nov 4, 2025
@bb-auto bb-auto bot added this to the 10.0.0 milestone Nov 4, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This patch reverts the manual relocation of the ImagePreviewer DOM element by removing both the appendChild call in init and the element removal in dispose, ensuring the preview component remains within its original container (fixes #7059).

Sequence diagram for ImagePreviewer DOM management changes

sequenceDiagram
participant JS as "ImagePreviewer.razor.js"
participant DOM as "DOM Container"
JS->>DOM: (Before) appendChild(el) on init
JS->>DOM: (Before) el.remove() on dispose
Note over JS,DOM: (After) No DOM relocation or removal
JS-->>DOM: el remains in original container throughout lifecycle
Loading

Class diagram for ImagePreviewer lifecycle changes

classDiagram
class ImagePreviewer {
  +init(id, prevList, config)
  +update(id, prevList)
  +dispose(id)
}
ImagePreviewer : -appendChild(el) (removed)
ImagePreviewer : -el.remove() (removed)
ImagePreviewer : Data.set(id, viewer)
ImagePreviewer : Viewer.init(el, prevList, config)
ImagePreviewer : Viewer.dispose(viewer.viewer)
Loading

File-Level Changes

Change Details Files
Revert DOM relocation behavior in ImagePreviewer
  • Deleted document.body.appendChild(el) from init
  • Deleted viewer.el.remove() from dispose
src/BootstrapBlazor/Components/ImagePreviewer/ImagePreviewer.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#7059 Revert the behavior in ImagePreviewer so that the DOM element is not moved to the end of the body.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary DOM manipulation from the ImagePreviewer component by eliminating manual element append and removal operations. Since the ImagePreviewer element is already managed by Blazor's rendering system, these JavaScript operations were redundant and potentially problematic.

  • Removed manual DOM element appending in the init function
  • Removed manual DOM element removal in the dispose function
  • Updated version numbers for both Visual Studio 17.0 and 18.0 builds

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ImagePreviewer.razor.js Removed unnecessary document.body.appendChild(el) and viewer.el.remove() calls since the element lifecycle is managed by Blazor
BootstrapBlazor.csproj Updated version from 9.12.1-beta02 to 9.12.1 (VS 17.0) and from 10.0.0-rc.2.2.2 to 10.0.0-rc.2.2.3 (VS 18.0)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (eaa2a93) to head (59bf0e7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7060   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        32534     32534           
  Branches      4510      4510           
=========================================
  Hits         32534     32534           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit a5b2c89 into main Nov 4, 2025
14 checks passed
@ArgoZhang ArgoZhang deleted the fix-preview branch November 4, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert(ImagePreview): do not move dom end of body

2 participants