-
-
Notifications
You must be signed in to change notification settings - Fork 374
chore(Config): update file encod to UTF-8 #7066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the charset override that was enforcing UTF-8 with BOM (utf-8-bom) for specific file types including C#, CSS, JavaScript, JSON, HTML, Razor, text, and log files. After this change, these files will inherit the global charset = utf-8 setting from line 11, meaning they will use UTF-8 without BOM.
Key Changes
- Removed the file-type-specific
charset = utf-8-bomconfiguration block - Affected file types will now default to UTF-8 without BOM (as set globally)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Code files | ||
| [*.{cs,csx,vb,vbx,css,scss}] | ||
| indent_size = 4 | ||
|
|
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the utf-8-bom charset setting for C# files (*.cs) may cause issues with the C# compiler and Visual Studio, which traditionally expect UTF-8 with BOM for source files. Consider keeping the BOM requirement at least for *.cs files to maintain compatibility with legacy tooling and avoid potential encoding-related issues.
| [*.cs] | |
| charset = utf-8-bom |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7066 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 32550 32550
Branches 4512 4512
=========================================
Hits 32550 32550
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7065
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Chores: