Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 12, 2025

Link issues

fixes #7099

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Add support for .NET 10 by updating target frameworks across the solution and test projects

Copilot AI review requested due to automatic review settings November 12, 2025 00:07
@bb-auto bb-auto bot added the enhancement New feature or request label Nov 12, 2025
@bb-auto bb-auto bot added this to the 10.0.0 milestone Nov 12, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 12, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) November 12, 2025 00:08
Copilot finished reviewing on behalf of ArgoZhang November 12, 2025 00:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for .NET 10.0 target framework and refactors test project configurations for improved maintainability.

  • Removes conditional versioning based on Visual Studio version, standardizing on .NET 10
  • Adds net10.0 to the target frameworks list (net6.0, net7.0, net8.0, net9.0, net10.0)
  • Centralizes test package references in test/Directory.Build.props
  • Reorganizes solution file structure with better folder grouping

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Version.props Removed Visual Studio version conditions, set net10.0 as default target framework and added it to multi-targeting list
src/BootstrapBlazor/BootstrapBlazor.csproj Removed conditional versioning, set version to 10.0.0
test/Directory.Build.props Centralized test package references (Microsoft.NET.Test.Sdk, xunit, coverlet), removed global Using directives
test/UnitTest/UnitTest.csproj Removed duplicated test package references, added project-specific Using directives
test/UnitTest.Localization/UnitTest.Localization.csproj Removed duplicated test package references, added project-specific Using directives
test/UnitTestDocs/UnitTestDocs.csproj Removed duplicated test package references and property group, removed obsolete Using Remove directives
test/UniTest.Sass/UniTest.Sass.csproj Cleaned up to minimal project file by removing package references and Using Remove directives
BootstrapBlazor.slnx Reorganized file structure with dedicated folders for props files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5e93bb5) to head (69e9024).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        32548     32548           
  Branches      4510      4510           
=========================================
  Hits         32548     32548           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 0ac5f7f into main Nov 12, 2025
14 checks passed
@ArgoZhang ArgoZhang deleted the feat-net10 branch November 12, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(TargetFramework): support net10

2 participants