-
-
Notifications
You must be signed in to change notification settings - Fork 363
test(Sass): remove ITestOutputHelper parameter #7110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR streamlines the Sass variable tests by removing the ITestOutputHelper injection and cleaning up related boilerplate in the test class. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7110 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 32548 32548
Branches 4510 4510
=========================================
Hits 32548 32548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes an unused ITestOutputHelper parameter from the VariableTest class in the Sass unit tests, addressing issue #7109. The parameter was declared in the constructor but was never referenced or used anywhere in the class.
- Removes unused constructor parameter from
VariableTestclass - Simplifies test class signature by removing unnecessary dependency injection
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Link issues
fixes #7109
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove ITestOutputHelper dependency from the Sass VariableTest class
Bug Fixes:
Enhancements: