Skip to content

feat(PdfReader): add ShowFileName parameter #7443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 2 commits into from
Dec 30, 2025
Merged

feat(PdfReader): add ShowFileName parameter #7443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54be4c0
feat(PdfReader): add ShowFileName parameter
ArgoZhang Dec 29, 2025
33e8701
chore: bump version 10.0.24
ArgoZhang Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<PackageReference Include="BootstrapBlazor.OfficeViewer" Version="10.0.0" />
<PackageReference Include="BootstrapBlazor.OnScreenKeyboard" Version="10.0.0" />
<PackageReference Include="BootstrapBlazor.OpcDa" Version="10.0.0" />
<PackageReference Include="BootstrapBlazor.PdfReader" Version="10.0.23" />
<PackageReference Include="BootstrapBlazor.PdfReader" Version="10.0.24" />
<PackageReference Include="BootstrapBlazor.PdfViewer" Version="10.0.0" />
<PackageReference Include="BootstrapBlazor.Player" Version="10.0.1" />
<PackageReference Include="BootstrapBlazor.RDKit" Version="10.0.0" />
Expand Down
8 changes: 7 additions & 1 deletion src/BootstrapBlazor.Server/Components/Samples/PdfReaders.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@
<Switch @bind-Value="_showToolbar"></Switch>
</BootstrapInputGroup>
</div>
<div class="col-12 col-sm-6">
<BootstrapInputGroup>
<BootstrapInputGroupLabel>ShowFileName</BootstrapInputGroupLabel>
<Switch @bind-Value="_showFileName"></Switch>
</BootstrapInputGroup>
</div>
<div class="col-12 col-sm-6">
<BootstrapInputGroup>
<BootstrapInputGroupLabel>ShowDownload</BootstrapInputGroupLabel>
Expand Down Expand Up @@ -53,6 +59,6 @@
</section>
<PdfReader Url="@_url" EnableThumbnails="_enableThumbnails"
ShowTwoPagesOneView="_showTwoPagesOneView" ShowDownload="_showDownload"
ShowToolbar="_showToolbar" ShowPrint="_showPrint"
ShowToolbar="_showToolbar" ShowPrint="_showPrint" ShowFileName="_showFileName"
Comment on lines 60 to +62
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boolean parameters passed to the PdfReader component are missing the @ symbol. In Blazor, when passing variable values as component parameters, you need to use @ to indicate it's a C# expression rather than a string literal. Without @, these parameters are being passed as the literal strings "_enableThumbnails", "_showTwoPagesOneView", etc., instead of the actual boolean values.

All boolean parameters on lines 60-62 need to be corrected:

  • EnableThumbnails should be EnableThumbnails="@_enableThumbnails"
  • ShowTwoPagesOneView should be ShowTwoPagesOneView="@_showTwoPagesOneView"
  • ShowDownload should be ShowDownload="@_showDownload"
  • ShowToolbar should be ShowToolbar="@_showToolbar"
  • ShowPrint should be ShowPrint="@_showPrint"
  • ShowFileName should be ShowFileName="@_showFileName"

This is a pre-existing issue affecting all parameters except Url, but it should be fixed as part of this PR since you're already modifying this line.

Copilot uses AI. Check for mistakes.
ViewHeight="600px" OnGetStreamAsync="OnGetStreamAsync"></PdfReader>
</DemoBlock>
1 change: 1 addition & 0 deletions src/BootstrapBlazor.Server/Components/Samples/PdfReaders.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public partial class PdfReaders
private bool _enableThumbnails = true;
private bool _showDownload = true;
private bool _showToolbar = true;
private bool _showFileName = true;
private string _url = "./samples/sample.pdf";
private string _streamFileName = "";

Expand Down
Loading