Merge pull request #55 from dotnetprojects/Sqlite

Foreign key adjustments

Author: jogibear9988

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_AddColumnTests.cs

@@ -1,6 +1,5 @@
 using System.Data;
 using System.Linq;
-using DotNetProjects.Migrator.Framework;
 using DotNetProjects.Migrator.Providers.Impl.SQLite;
 using Migrator.Framework;
 using Migrator.Tests.Providers.SQLite.Base;

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_AddForeignKeyTests.cs

@@ -19,7 +19,7 @@ public void AddForeignKey()
         Provider.ExecuteNonQuery("INSERT INTO TestTwo (TestId) VALUES (1)");
 
         // Act
-        Provider.AddForeignKey("FK name is not supported by SQLite", parentTable: "Test", parentColumn: "Id", childTable: "TestTwo", childColumn: "TestId", ForeignKeyConstraintType.Cascade);
+        Provider.AddForeignKey(name: "FK name is not supported by SQLite", childTable: "TestTwo", childColumn: "TestId", parentTable: "Test", parentColumn: "Id", constraint: ForeignKeyConstraintType.Cascade);
 
         // Assert
         var foreignKeyConstraints = ((SQLiteTransformationProvider)Provider).GetForeignKeyConstraints("TestTwo");
@@ -48,7 +48,7 @@ public void AddForeignKey_RenameParentColumWithForeignKeyAndData_ForeignKeyPoint
         Provider.ExecuteNonQuery("INSERT INTO TestTwo (TestId) VALUES (1)");
 
         // Act
-        Provider.AddForeignKey("FK name is not supported by SQLite", parentTable: "Test", parentColumn: "Id", childTable: "TestTwo", childColumn: "TestId", ForeignKeyConstraintType.Cascade);
+        Provider.AddForeignKey(name: "FK name is not supported by SQLite", childTable: "TestTwo", childColumn: "TestId", parentTable: "Test", parentColumn: "Id", constraint: ForeignKeyConstraintType.Cascade);
 
         // Rename column in parent
         Provider.RenameColumn("Test", "Id", "IdNew");

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_ChangeColumnTests.cs

@@ -58,16 +58,4 @@ public void ChangeColumn_HavingColumnPropertyUniqueAndIndex_RebuildSucceeds()
         Assert.That(indexAfter.Name, Is.EqualTo(indexName));
         CollectionAssert.AreEquivalent(indexAfter.KeyColumns, new string[] { propertyName1, propertyName2 });
     }
-}
-
-
-
-
-
-
-
-
-
-
-
-
+}

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_CheckForeignKeyIntegrityTests.cs

@@ -16,7 +16,7 @@ public void CheckForeignKeyIntegrity_IntegrityViolated_ReturnsFalse()
         AddTableWithPrimaryKey();
         Provider.ExecuteNonQuery("INSERT INTO Test (Id, name) VALUES (1, 'my name')");
         Provider.ExecuteNonQuery("INSERT INTO TestTwo (TestId) VALUES (44444)");
-        Provider.AddForeignKey("FK name is not supported by SQLite", parentTable: "Test", parentColumn: "Id", childTable: "TestTwo", childColumn: "TestId", ForeignKeyConstraintType.Cascade);
+        Provider.AddForeignKey(name: "FK name is not supported by SQLite", childTable: "TestTwo", childColumn: "TestId", parentTable: "Test", parentColumn: "Id", constraint: ForeignKeyConstraintType.Cascade);
 
         // Act
         var result = ((SQLiteTransformationProvider)Provider).CheckForeignKeyIntegrity();
@@ -32,7 +32,7 @@ public void CheckForeignKeyIntegrity_IntegrityOk_ReturnsTrue()
         AddTableWithPrimaryKey();
         Provider.ExecuteNonQuery("INSERT INTO Test (Id, name) VALUES (1, 'my name')");
         Provider.ExecuteNonQuery("INSERT INTO TestTwo (TestId) VALUES (1)");
-        Provider.AddForeignKey("FK name is not supported by SQLite", parentTable: "Test", parentColumn: "Id", childTable: "TestTwo", childColumn: "TestId", ForeignKeyConstraintType.Cascade);
+        Provider.AddForeignKey(name: "FK name is not supported by SQLite", childTable: "TestTwo", childColumn: "TestId", parentTable: "Test", parentColumn: "Id", constraint: ForeignKeyConstraintType.Cascade);
 
         // Act
         var result = ((SQLiteTransformationProvider)Provider).CheckForeignKeyIntegrity();

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_PRAGMAForeignKeys.cs

@@ -0,0 +1,53 @@
+
+
+
+
+// Does not work because we cannot reuse the connection at this point in time.
+
+
+
+
+
+
+// using System.Data;
+// using DotNetProjects.Migrator.Providers.Impl.SQLite;
+// using Migrator.Framework;
+// using Migrator.Tests.Providers.SQLite.Base;
+// using NUnit.Framework;
+
+// namespace Migrator.Tests.Providers.SQLite;
+
+// [TestFixture]
+// [Category("SQLite")]
+// public class SQLiteTransformationProvider_PRAGMAForeignKeysTests : SQLiteTransformationProviderTestBase
+// {
+//     [Test, Description("Tests the set ON indirectly. Integrity violation should throw.")]
+//     public void PragmaForeignKeys_IntegrityViolation_Throws()
+//     {
+//         const string parentTableName = "ParentTable";
+//         const string childTableName = "ChildTable";
+//         const string propertyIdName = "Id";
+//         const string foreignKeyColumnName = "ParentId";
+
+//         Provider.AddTable(parentTableName, new Column(propertyIdName, DbType.Int32, ColumnProperty.PrimaryKey));
+//         Provider.AddTable(childTableName, new Column(propertyIdName, DbType.Int32, ColumnProperty.PrimaryKey), new Column(foreignKeyColumnName, DbType.Int32));
+
+//         ((SQLiteTransformationProvider)Provider).BeginTransaction();
+//         ((SQLiteTransformationProvider)Provider).SetPragmaForeignKeys(false);
+//         var pragmaForeignKeyState1 = ((SQLiteTransformationProvider)Provider).IsPragmaForeignKeysOn();
+
+//         Provider.ExecuteNonQuery($"INSERT INTO {parentTableName} ({propertyIdName}) VALUES (1)");
+
+//         // Integrity violation does not throw due to set OFF validation
+//         Provider.ExecuteNonQuery($"INSERT INTO {childTableName} ({propertyIdName}, {foreignKeyColumnName}) VALUES (1, 999)");
+
+//         Provider.ExecuteNonQuery($"DELETE FROM {childTableName}");
+
+//         ((SQLiteTransformationProvider)Provider).SetPragmaForeignKeys(true);
+//         var pragmaForeignKeyState2 = ((SQLiteTransformationProvider)Provider).IsPragmaForeignKeysOn();
+
+
+//         Assert.That(pragmaForeignKeyState1, Is.False);
+//         Assert.That(pragmaForeignKeyState2, Is.True);
+//     }
+// }

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_RemoveColumnTests.cs

@@ -76,11 +76,11 @@ public void RemoveColumn_HavingASingleForeignKeyPointingToTheTargetColumn_Single
         );
 
         Provider.AddTable(childTestTableName, new Column(propertyChildTableName1, DbType.Int32));
-        Provider.AddForeignKey("Not used in SQLite", testTableName, propertyName1, childTestTableName, propertyChildTableName1);
+        Provider.AddForeignKey("Not used in SQLite", childTestTableName, propertyChildTableName1, testTableName, propertyName1);
         var script = ((SQLiteTransformationProvider)Provider).GetSqlCreateTableScript(childTestTableName);
 
         Provider.AddTable(childTestTableName2, new Column(propertyChildTableName1, DbType.Int32));
-        Provider.AddForeignKey("Not used in SQLite", testTableName, propertyName2, childTestTableName2, propertyChildTableName1);
+        Provider.AddForeignKey(name: "Not used in SQLite", childTable: childTestTableName2, childColumn: propertyChildTableName1, parentTable: testTableName, parentColumn: propertyName2);
 
         var tableInfoBefore = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(testTableName);
         var tableInfoChildBefore = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(childTestTableName);

src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_RenameColumnTests.cs

@@ -36,8 +36,8 @@ public void RenameColumn_HavingASingleForeignKeyPointingToTheTargetColumn_Single
             new Column(propertyLevel2Id, DbType.Int32)
         );
 
-        Provider.AddForeignKey("Level2ToLevel1", tableNameLevel1, propertyId, tableNameLevel2, propertyLevel1Id);
-        Provider.AddForeignKey("Level3ToLevel2", tableNameLevel2, propertyId, tableNameLevel3, propertyLevel2Id);
+        Provider.AddForeignKey("Level2ToLevel1", tableNameLevel2, propertyLevel1Id, tableNameLevel1, propertyId);
+        Provider.AddForeignKey("Level3ToLevel2", tableNameLevel3, propertyLevel2Id, tableNameLevel2, propertyId);
 
         var script = ((SQLiteTransformationProvider)Provider).GetSqlCreateTableScript(tableNameLevel2);