Merge pull request #51 from dotnetprojects/Sqlite

Updates RemoveColumn and RenameColumn

Author: jogibear9988

src/Migrator.Tests/Providers/Base/TransformationProviderBase.cs

@@ -7,147 +7,147 @@ namespace Migrator.Tests.Providers
     /// <summary>
     /// Base class for Provider tests for all tests including constraint oriented tests.
     /// </summary>
-    public class TransformationProviderConstraintBase : TransformationProviderBase
+    public abstract class TransformationProviderConstraintBase : TransformationProviderBase
     {
         public void AddForeignKey()
         {
             AddTableWithPrimaryKey();
-            _provider.AddForeignKey("FK_Test_TestTwo", "TestTwo", "TestId", "Test", "Id");
+            Provider.AddForeignKey("FK_Test_TestTwo", "TestTwo", "TestId", "Test", "Id");
         }
 
         public void AddPrimaryKey()
         {
             AddTable();
-            _provider.AddPrimaryKey("PK_Test", "Test", "Id");
+            Provider.AddPrimaryKey("PK_Test", "Test", "Id");
         }
 
         public void AddUniqueConstraint()
         {
-            _provider.AddUniqueConstraint("UN_Test_TestTwo", "TestTwo", "TestId");
+            Provider.AddUniqueConstraint("UN_Test_TestTwo", "TestTwo", "TestId");
         }
 
         public void AddMultipleUniqueConstraint()
         {
-            _provider.AddUniqueConstraint("UN_Test_TestTwo", "TestTwo", "Id", "TestId");
+            Provider.AddUniqueConstraint("UN_Test_TestTwo", "TestTwo", "Id", "TestId");
         }
 
         public void AddCheckConstraint()
         {
-            _provider.AddCheckConstraint("CK_TestTwo_TestId", "TestTwo", "TestId>5");
+            Provider.AddCheckConstraint("CK_TestTwo_TestId", "TestTwo", "TestId>5");
         }
 
         [Test]
         public void CanAddPrimaryKey()
         {
             AddPrimaryKey();
-            Assert.That(_provider.PrimaryKeyExists("Test", "PK_Test"), Is.True);
+            Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True);
         }
 
         [Test]
         public void AddIndexedColumn()
         {
-            _provider.AddColumn("TestTwo", "Test", DbType.String, 50, ColumnProperty.Indexed);
+            Provider.AddColumn("TestTwo", "Test", DbType.String, 50, ColumnProperty.Indexed);
         }
 
         [Test]
         public void AddUniqueColumn()
         {
-            _provider.AddColumn("TestTwo", "Test", DbType.String, 50, ColumnProperty.Unique);
+            Provider.AddColumn("TestTwo", "Test", DbType.String, 50, ColumnProperty.Unique);
         }
 
         [Test]
         public void CanAddForeignKey()
         {
             AddForeignKey();
-            Assert.That(_provider.ConstraintExists("TestTwo", "FK_Test_TestTwo"), Is.True);
+            Assert.That(Provider.ConstraintExists("TestTwo", "FK_Test_TestTwo"), Is.True);
         }
 
         [Test]
         public virtual void CanAddUniqueConstraint()
         {
             AddUniqueConstraint();
-            Assert.That(_provider.ConstraintExists("TestTwo", "UN_Test_TestTwo"), Is.True);
+            Assert.That(Provider.ConstraintExists("TestTwo", "UN_Test_TestTwo"), Is.True);
         }
 
         [Test]
         public virtual void CanAddMultipleUniqueConstraint()
         {
             AddMultipleUniqueConstraint();
-            Assert.That(_provider.ConstraintExists("TestTwo", "UN_Test_TestTwo"), Is.True);
+            Assert.That(Provider.ConstraintExists("TestTwo", "UN_Test_TestTwo"), Is.True);
         }
 
         [Test]
         public virtual void CanAddCheckConstraint()
         {
             AddCheckConstraint();
-            Assert.That(_provider.ConstraintExists("TestTwo", "CK_TestTwo_TestId"), Is.True);
+            Assert.That(Provider.ConstraintExists("TestTwo", "CK_TestTwo_TestId"), Is.True);
         }
 
         [Test]
         public void RemoveForeignKey()
         {
             AddForeignKey();
-            _provider.RemoveForeignKey("TestTwo", "FK_Test_TestTwo");
-            Assert.That(_provider.ConstraintExists("TestTwo", "FK_Test_TestTwo"), Is.False);
+            Provider.RemoveForeignKey("TestTwo", "FK_Test_TestTwo");
+            Assert.That(Provider.ConstraintExists("TestTwo", "FK_Test_TestTwo"), Is.False);
         }
 
         [Test]
         public void RemoveUniqueConstraint()
         {
             AddUniqueConstraint();
-            _provider.RemoveConstraint("TestTwo", "UN_Test_TestTwo");
-            Assert.That(_provider.ConstraintExists("TestTwo", "UN_Test_TestTwo"), Is.False);
+            Provider.RemoveConstraint("TestTwo", "UN_Test_TestTwo");
+            Assert.That(Provider.ConstraintExists("TestTwo", "UN_Test_TestTwo"), Is.False);
         }
 
         [Test]
         public virtual void RemoveCheckConstraint()
         {
             AddCheckConstraint();
-            _provider.RemoveConstraint("TestTwo", "CK_TestTwo_TestId");
-            Assert.That(_provider.ConstraintExists("TestTwo", "CK_TestTwo_TestId"), Is.False);
+            Provider.RemoveConstraint("TestTwo", "CK_TestTwo_TestId");
+            Assert.That(Provider.ConstraintExists("TestTwo", "CK_TestTwo_TestId"), Is.False);
         }
 
         [Test]
         public void RemoveUnexistingForeignKey()
         {
             AddForeignKey();
-            _provider.RemoveForeignKey("abc", "FK_Test_TestTwo");
-            _provider.RemoveForeignKey("abc", "abc");
-            _provider.RemoveForeignKey("Test", "abc");
+            Provider.RemoveForeignKey("abc", "FK_Test_TestTwo");
+            Provider.RemoveForeignKey("abc", "abc");
+            Provider.RemoveForeignKey("Test", "abc");
         }
 
         [Test]
         public void ConstraintExist()
         {
             AddForeignKey();
-            Assert.That(_provider.ConstraintExists("TestTwo", "FK_Test_TestTwo"), Is.True);
-            Assert.That(_provider.ConstraintExists("abc", "abc"), Is.False);
+            Assert.That(Provider.ConstraintExists("TestTwo", "FK_Test_TestTwo"), Is.True);
+            Assert.That(Provider.ConstraintExists("abc", "abc"), Is.False);
         }
 
         [Test]
         public void AddTableWithCompoundPrimaryKey()
         {
-            _provider.AddTable("Test",
+            Provider.AddTable("Test",
                                new Column("PersonId", DbType.Int32, ColumnProperty.PrimaryKey),
                                new Column("AddressId", DbType.Int32, ColumnProperty.PrimaryKey)
             );
 
-            Assert.That(_provider.TableExists("Test"), Is.True, "Table doesn't exist");
-            Assert.That(_provider.PrimaryKeyExists("Test", "PK_Test"), Is.True, "Constraint doesn't exist");
+            Assert.That(Provider.TableExists("Test"), Is.True, "Table doesn't exist");
+            Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True, "Constraint doesn't exist");
         }
 
         [Test]
         public void AddTableWithCompoundPrimaryKeyShouldKeepNullForOtherProperties()
         {
-            _provider.AddTable("Test",
+            Provider.AddTable("Test",
                                new Column("PersonId", DbType.Int32, ColumnProperty.PrimaryKey),
                                new Column("AddressId", DbType.Int32, ColumnProperty.PrimaryKey),
                                new Column("Name", DbType.String, 30, ColumnProperty.Null)
                 );
-            Assert.That(_provider.TableExists("Test"), Is.True, "Table doesn't exist");
-            Assert.That(_provider.PrimaryKeyExists("Test", "PK_Test"), Is.True, "Constraint doesn't exist");
+            Assert.That(Provider.TableExists("Test"), Is.True, "Table doesn't exist");
+            Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True, "Constraint doesn't exist");
 
-            Column column = _provider.GetColumnByName("Test", "Name");
+            Column column = Provider.GetColumnByName("Test", "Name");
             Assert.That(column, Is.Not.Null);
             Assert.That((column.ColumnProperty & ColumnProperty.Null) == ColumnProperty.Null, Is.True);
         }

…/TransformationProviderConstraintBase.cs …/TransformationProviderConstraintBase.cssrc/Migrator.Tests/Providers/TransformationProviderConstraintBase.cs renamed to src/Migrator.Tests/Providers/Base/TransformationProviderConstraintBase.cs src/Migrator.Tests/Providers/TransformationProviderConstraintBase.cs renamed to src/Migrator.Tests/Providers/Base/TransformationProviderConstraintBase.cs

@@ -0,0 +1,78 @@
+using System;
+using System.Data;
+using Migrator.Framework;
+using NUnit.Framework;
+
+namespace Migrator.Tests.Providers.Base;
+
+public abstract class TransformationProviderSimpleBase
+{
+    protected ITransformationProvider Provider;
+
+    [TearDown]
+    public virtual void TearDown()
+    {
+        DropTestTables();
+
+        Provider.Rollback();
+    }
+
+    protected void DropTestTables()
+    {
+        // Because MySql doesn't support schema transaction
+        // we got to remove the tables manually... sad...
+        try
+        {
+            Provider.RemoveTable("TestTwo");
+        }
+        catch (Exception)
+        {
+        }
+        try
+        {
+            Provider.RemoveTable("Test");
+        }
+        catch (Exception)
+        {
+        }
+        try
+        {
+            Provider.RemoveTable("SchemaInfo");
+        }
+        catch (Exception)
+        {
+        }
+    }
+
+    public void AddDefaultTable()
+    {
+        Provider.AddTable("TestTwo",
+            new Column("Id", DbType.Int32, ColumnProperty.PrimaryKey),
+            new Column("TestId", DbType.Int32, ColumnProperty.ForeignKey)
+        );
+    }
+
+    public void AddTable()
+    {
+        Provider.AddTable("Test",
+            new Column("Id", DbType.Int32, ColumnProperty.NotNull),
+            new Column("Title", DbType.String, 100, ColumnProperty.Null),
+            new Column("name", DbType.String, 50, ColumnProperty.Null),
+            new Column("blobVal", DbType.Binary, ColumnProperty.Null),
+            new Column("boolVal", DbType.Boolean, ColumnProperty.Null),
+            new Column("bigstring", DbType.String, 50000, ColumnProperty.Null)
+        );
+    }
+
+    public void AddTableWithPrimaryKey()
+    {
+        Provider.AddTable("Test",
+            new Column("Id", DbType.Int32, ColumnProperty.PrimaryKeyWithIdentity),
+            new Column("Title", DbType.String, 100, ColumnProperty.Null),
+            new Column("name", DbType.String, 50, ColumnProperty.NotNull),
+            new Column("blobVal", DbType.Binary),
+            new Column("boolVal", DbType.Boolean),
+            new Column("bigstring", DbType.String, 50000)
+        );
+    }
+}

src/Migrator.Tests/Providers/Base/TransformationProviderSimpleBase.cs

@@ -18,46 +18,45 @@
 using Migrator.Providers.Mysql;
 using NUnit.Framework;
 
-namespace Migrator.Tests.Providers
+namespace Migrator.Tests.Providers;
+
+[TestFixture]
+[Category("MySql")]
+public class MySqlTransformationProviderTest : TransformationProviderConstraintBase
 {
-    [TestFixture]
-    [Category("MySql")]
-    public class MySqlTransformationProviderTest : TransformationProviderConstraintBase
+    #region Setup/Teardown
+
+    [SetUp]
+    public void SetUp()
+    {
+        var constr = ConfigurationManager.AppSettings["MySqlConnectionString"];
+        if (constr == null)
+            throw new ArgumentNullException("MySqlConnectionString", "No config file");
+        Provider = new MySqlTransformationProvider(new MysqlDialect(), constr, "default", null);
+        // _provider.Logger = new Logger(true, new ConsoleWriter());
+
+        AddDefaultTable();
+    }
+
+    [TearDown]
+    public override void TearDown()
+    {
+        DropTestTables();
+    }
+
+    #endregion
+
+    // [Test,Ignore("MySql doesn't support check constraints")]
+    public override void CanAddCheckConstraint()
+    {
+    }
+
+    [Test]
+    public void AddTableWithMyISAMEngine()
     {
-        #region Setup/Teardown
-
-        [SetUp]
-        public void SetUp()
-        {
-            string constr = ConfigurationManager.AppSettings["MySqlConnectionString"];
-            if (constr == null)
-                throw new ArgumentNullException("MySqlConnectionString", "No config file");
-            _provider = new MySqlTransformationProvider(new MysqlDialect(), constr, "default", null);
-            // _provider.Logger = new Logger(true, new ConsoleWriter());
-
-            AddDefaultTable();
-        }
-
-        [TearDown]
-        public override void TearDown()
-        {
-            DropTestTables();
-        }
-
-        #endregion
-
-        // [Test,Ignore("MySql doesn't support check constraints")]
-        public override void CanAddCheckConstraint()
-        {
-        }
-
-        [Test]
-        public void AddTableWithMyISAMEngine()
-        {
-            _provider.AddTable("Test", "MyISAM",
-                               new Column("Id", DbType.Int32, ColumnProperty.NotNull),
-                               new Column("name", DbType.String, 50)
-                );
-        }
+        Provider.AddTable("Test", "MyISAM",
+                           new Column("Id", DbType.Int32, ColumnProperty.NotNull),
+                           new Column("name", DbType.String, 50)
+            );
     }
 }