-
Notifications
You must be signed in to change notification settings - Fork 651
fix: Best-effort use of chat completion #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ki-Seki
wants to merge
15
commits into
dottxt-ai:main
Choose a base branch
from
Ki-Seki:fix/chat-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+233
−37
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ecd6ade
feat: add chat template checking func
Ki-Seki 9349453
fix: Best-effort use of chat completion for VLLMOffline
Ki-Seki a3c8234
fix: Best-effort use of chat completion for Transformers
Ki-Seki 6a173d3
fix: Best-effort use of chat completion for mlxlm
Ki-Seki d2876a2
fix: Best-effort use of chat completion for LlamaCpp
Ki-Seki 5d11e62
test: Add some initial tests
Ki-Seki ab2bf4a
fix: update stream tests to handle potential empty chunks
Ki-Seki 0d86a1e
fix: add chat_mode parameter to LlamaCpp and from_llamacpp for better…
Ki-Seki d0a6420
fix: remove TODO comments for adding tests in LlamaCpp class methods
Ki-Seki 730d84a
fix: improve error handling for unexpected prompt types and update st…
Ki-Seki eafea53
test: simplify some tests
Ki-Seki 8767873
fix: add tests for _check_hf_chat_template function in tokenizer module
Ki-Seki 899f0b1
fix: remove unused AnyTokenizer import from vllm_offline.py
Ki-Seki ba22fb9
fix: correct typo
Ki-Seki 1744cb0
fix: move tokenizer imports to the appropriate location in vllm_offli…
Ki-Seki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.