Skip to content

Update dep#88

Open
doubleailes wants to merge 1 commit intomainfrom
update_dependencies
Open

Update dep#88
doubleailes wants to merge 1 commit intomainfrom
update_dependencies

Conversation

@doubleailes
Copy link
Owner

@doubleailes doubleailes commented Sep 26, 2025

PR Type

Other


Description

  • Update glam from 0.30.1 to 0.30.8

  • Update clap from 4.5.34 to 4.5.48

  • Update tracing-subscriber from 0.3.19 to 0.3.20

  • Centralize rand dependency to workspace level


Diagram Walkthrough

flowchart LR
  workspace["Workspace Cargo.toml"] --> glam["glam 0.30.1 → 0.30.8"]
  workspace --> rand["rand centralized"]
  render["crust-render"] --> clap["clap 4.5.34 → 4.5.48"]
  render --> tracing["tracing-subscriber 0.3.19 → 0.3.20"]
  core["crust-core"] --> rand
  utils["utils"] --> rand
Loading

File Walkthrough

Relevant files
Dependencies
Cargo.toml
Update glam and add workspace rand                                             

Cargo.toml

  • Update glam version from 0.30.1 to 0.30.8
  • Add rand 0.9.2 as workspace dependency
+3/-2     
Cargo.toml
Switch to workspace rand dependency                                           

crates/crust-core/Cargo.toml

  • Remove local rand 0.9.0 dependency
  • Add workspace rand dependency reference
+1/-1     
Cargo.toml
Update clap and tracing-subscriber versions                           

crates/crust-render/Cargo.toml

  • Update clap from 4.5.34 to 4.5.48
  • Update tracing-subscriber from 0.3.19 to 0.3.20
+2/-2     
Cargo.toml
Use workspace rand dependency                                                       

crates/utils/Cargo.toml

  • Replace local rand 0.9.0 with workspace reference
+1/-1     

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes dependency management by moving individual crate dependencies to the workspace level and updates several package versions.

  • Consolidates rand dependency management to workspace level
  • Updates clap, tracing-subscriber, and glam to newer versions
  • Removes duplicate dependency declarations across crates

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Cargo.toml Adds workspace-level rand dependency and updates glam version
crates/utils/Cargo.toml Changes from direct rand dependency to workspace reference
crates/crust-render/Cargo.toml Updates clap and tracing-subscriber versions
crates/crust-core/Cargo.toml Removes direct rand dependency and adds workspace reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Workspace Consistency

Verify all crates that used rand now consistently pull from the workspace and that versions align across lockfile; ensure no residual direct rand specs remain in other crate manifests or build scripts.

glam = { version = "0.30.8", features = ["serde"] }
tracing = {version = "0.1.41", default-features = false}
exr = "1.73.0"
rand = "0.9.2"
Dep Bump Impact

Check for breaking or behavior changes from updating clap to 4.5.48 and tracing-subscriber to 0.3.20, particularly feature flags and default-features assumptions in binary parsing/log formatting.

clap = { version = "4.5.48", features = ["derive"] }
tracing.workspace = true
exr.workspace = true

[dependencies.tracing-subscriber]
version = "0.3.20"
features = ["fmt"]
Build Reproducibility

Confirm that moving rand to workspace and enabling glam via workspace doesn’t alter feature resolution; consider pinning via [workspace.dependencies] to avoid unintended feature unification across crates.

glam.workspace = true
tracing.workspace = true
exr.workspace = true
rand.workspace = true

@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants