[Snyk] Security upgrade python from 3.13.7-slim to 3.14.2-slim #15
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174592 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174592 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174602 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174605 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174605
Summary of ChangesHello @doublegate, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Python base image for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request from Snyk aims to improve security by upgrading the Python base image from 3.13.7-slim to 3.14.2-slim in the safety-guardian service's Dockerfile. While this is a necessary security update, the current change will break the Docker build due to a hardcoded Python version path in a COPY instruction. I have added a critical review comment explaining the issue and suggesting a fix. Furthermore, I've identified several other Dockerfiles in the repository that use the same vulnerable base image; these should also be updated to ensure consistent security across all services.
| # syntax=docker/dockerfile:1 | ||
| # Safety Guardian Arm Dockerfile - Multi-stage build for Python service | ||
| FROM python:3.13.7-slim as builder | ||
| FROM python:3.14.2-slim as builder |
There was a problem hiding this comment.
Upgrading the Python base image is important for security. However, this change as-is will break the Docker build. The COPY instruction on line 41, which copies dependencies from the builder stage, uses a hardcoded path with the old Python version: /usr/local/lib/python3.13/site-packages.
With the base image updated to python:3.14.2-slim, the correct path for site-packages will be /usr/local/lib/python3.14/site-packages. You need to update line 41 to use this new path for both the source and destination of the COPY command.
To make this Dockerfile more robust for future upgrades, consider using a build argument for the Python version. For example:
ARG PYTHON_VERSION_MAJOR_MINOR=3.14
ARG PYTHON_VERSION_FULL=3.14.2
FROM python:${PYTHON_VERSION_FULL}-slim as builder
...
# Runtime stage
FROM python:${PYTHON_VERSION_FULL}-slim
...
COPY --from=builder /usr/local/lib/python${PYTHON_VERSION_MAJOR_MINOR}/site-packages /usr/local/lib/python${PYTHON_VERSION_MAJOR_MINOR}/site-packagesApplying this pattern across all your Python Dockerfiles would prevent this kind of issue from recurring.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Copy site-packages from wrong Python version path
The base images were bumped to python:3.14.2-slim, but the runtime stage still copies dependencies from /usr/local/lib/python3.13/site-packages. With Python 3.14 this source directory does not exist, so the Docker build will fail at the copy step or, if the directory appears empty, the container will start without any installed packages. Update the copy path to match the Python 3.14 lib directory.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR proposes a security upgrade of the Python base image from version 3.13.7-slim to 3.14.2-slim in the Safety Guardian service Dockerfile to address OpenSSL-related vulnerabilities. However, Python 3.14.2 does not exist as a valid release - Python 3.14 has not been released yet as of early 2025.
Key changes:
- Updates builder stage base image from
python:3.13.7-slimtopython:3.14.2-slim - Updates runtime stage base image from
python:3.13.7-slimtopython:3.14.2-slim
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Snyk has created this PR to fix 3 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
services/arms/safety-guardian/DockerfileWe recommend upgrading to
python:3.14.2-slim, as this image has only 23 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-DEBIAN13-OPENSSL-13174592
SNYK-DEBIAN13-OPENSSL-13174592
SNYK-DEBIAN13-OPENSSL-13174602
SNYK-DEBIAN13-OPENSSL-13174605
SNYK-DEBIAN13-OPENSSL-13174605
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.