-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade python from 3.13.7-slim to 3.14.2-slim #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174592 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174592 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174602 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174605 - https://snyk.io/vuln/SNYK-DEBIAN13-OPENSSL-13174605
Summary of ChangesHello @doublegate, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical security enhancement by updating the Python base image within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by Snyk, upgrades the Python base image from 3.13.7-slim to 3.14.2-slim in the services/arms/judge/Dockerfile to fix security vulnerabilities. While this is a necessary security update, it introduces a breaking change. The Dockerfile contains a hardcoded path with the old Python version (3.13) for copying packages between build stages. This path needs to be updated to 3.14 to prevent the Docker build from failing. I've added a critical comment highlighting this issue and suggesting a fix.
|
|
||
| # Runtime stage | ||
| FROM python:3.13.7-slim | ||
| FROM python:3.14.2-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While upgrading the Python version is a good security practice, this change will break the Docker build. The COPY instruction on line 41 has a hardcoded Python version (3.13) in the path.
# line 41
COPY --from=builder /usr/local/lib/python3.13/site-packages /usr/local/lib/python3.13/site-packagesWith this upgrade to Python 3.14, the path needs to be updated to .../python3.14/... for the COPY command to find the source files. Without this change, the build will fail.
Recommendation:
Update line 41 to:
COPY --from=builder /usr/local/lib/python3.14/site-packages /usr/local/lib/python3.14/site-packagesLong-term improvement:
To make future Python upgrades easier, consider using a build argument for the Python version throughout the Dockerfile. This avoids hardcoding the version in multiple places.
Example:
ARG PYTHON_MAJOR_MINOR_VERSION=3.14
ARG PYTHON_FULL_VERSION=3.14.2
FROM python:${PYTHON_FULL_VERSION}-slim as builder
# ...
# Runtime stage
FROM python:${PYTHON_FULL_VERSION}-slim
# ...
# Copy installed packages from builder
COPY --from=builder /usr/local/lib/python${PYTHON_MAJOR_MINOR_VERSION}/site-packages /usr/local/lib/python${PYTHON_MAJOR_MINOR_VERSION}/site-packagesThis way, you'd only need to update the ARG values for future upgrades.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the Python Docker base image from 3.13.7-slim to 3.14.2-slim to address security vulnerabilities in OpenSSL dependencies (CVE-2025-9230, CVE-2025-9231, CVE-2025-9232).
Key Changes:
- Updated builder stage FROM instruction to use Python 3.14.2-slim
- Updated runtime stage FROM instruction to use Python 3.14.2-slim
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Snyk has created this PR to fix 3 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
services/arms/judge/DockerfileWe recommend upgrading to
python:3.14.2-slim, as this image has only 23 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-DEBIAN13-OPENSSL-13174592
SNYK-DEBIAN13-OPENSSL-13174592
SNYK-DEBIAN13-OPENSSL-13174602
SNYK-DEBIAN13-OPENSSL-13174605
SNYK-DEBIAN13-OPENSSL-13174605
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.