-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade python from 3.13.7-slim to 3.14.2-slim #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doublegate
wants to merge
1
commit into
main
Choose a base branch
from
snyk-fix-d3a6a0929efa77ff9e20589efb0bc542
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to Python 3.14 will cause the Docker build to fail. The
COPYinstruction on line 41, which copies packages from the builder stage to the runtime stage, has a hardcoded path for Python 3.13.Because both the builder stage (updated here on line 3) and the runtime stage (updated on line 26) now use Python 3.14, this path is incorrect for both the source and destination. The build will fail with a 'file not found' error.
To fix this, line 41 must be updated to use the Python 3.14 path:
COPY --from=builder /usr/local/lib/python3.14/site-packages /usr/local/lib/python3.14/site-packagesTo make this file more robust for future upgrades, I recommend using a build argument to define the Python version and using it to construct the path, avoiding hardcoded version numbers.