Skip to content

Claude/fix workflow and link 018u x woggz z3w e5 w4w by vtkg #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doublegate merged 2 commits into from
Nov 18, 2025
Merged

Claude/fix workflow and link 018u x woggz z3w e5 w4w by vtkg #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e727669
fix(docs): Convert dead rust-ffi-guide URL to plain text in SPRINT-5.…
claude Nov 18, 2025
db20e73
Fix syntax error in markdown links workflow
doublegate Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/markdown-links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
- name: Check links in root markdown files
run: |
echo "::group::Checking root markdown files"
for file in CHANGELOG.md CONTRIBUTING.md SECURITY.md AUTHORS.md SUPPORT.md 2>/dev/null; do
for file in CHANGELOG.md CONTRIBUTING.md SECURITY.md AUTHORS.md SUPPORT.md; do
if [ -f "$file" ]; then
echo "Checking: $file"
markdown-link-check "$file" --config mlc_config.json || exit 1
Expand Down
2 changes: 1 addition & 1 deletion to-dos/PHASE-5/SPRINT-5.8-TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,7 +1217,7 @@ repository = "https://github.com/prtip/plugins/http-enum"
**Best Practices:**
- Plugin architecture patterns: https://martinfowler.com/
- Trait-based plugins in Rust: https://adventures.michaelfbryan.com/posts/plugins-in-rust/
- Dynamic loading in Rust: https://michael-f-bryan.github.io/rust-ffi-guide/
- Dynamic loading in Rust: michael-f-bryan.github.io/rust-ffi-guide (archived/moved)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While converting the dead link to plain text is a good way to fix the build, it would be more helpful for future readers to replace it with an updated, working resource. The author of the original guide recommends 'The Rust FFI Omnibus' as a replacement.

Consider updating the link to point to the FFI section of the Rust CLI book, which is actively maintained.

Suggested change
- Dynamic loading in Rust: michael-f-bryan.github.io/rust-ffi-guide (archived/moved)
- Dynamic loading in Rust: https://rust-cli.github.io/book/interop/ffi.html

Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plain text URL reference is inconsistent with surrounding entries. Lines 1218-1219 use working HTTPS links. Consider one of these alternatives: (1) If a replacement URL exists (e.g., Web Archive snapshot), use that instead. (2) Remove this entry entirely if no accessible alternative exists. (3) If keeping for historical reference, maintain consistency with the pattern used in line 2139 of docs/27-TLS-CERTIFICATE-GUIDE.md (plain domain without protocol prefix).

Suggested change
- Dynamic loading in Rust: michael-f-bryan.github.io/rust-ffi-guide (archived/moved)
- Dynamic loading in Rust: https://web.archive.org/web/20230101000000/https://michael-f-bryan.github.io/rust-ffi-guide/ (archived)

Copilot uses AI. Check for mistakes.

---

Expand Down
Loading