fix: use spec value by default, allow json schema value as alias #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the JSON schema lists `OPERATING_SYSTEM`, the spec actually says `OPERATING-SYSTEM` (dash). This changes to serialize as the spec says, but allows to also read as the JSON schema says.
|
@mmurto Is there a chance to get a new release of this? |
Yeah, I'll take a look as soon as I'm able. |
|
I'll clean up the clippy warnings in the meantime. |
ctron
added a commit
to ctron/trustify
that referenced
this pull request
Mar 31, 2025
ctron
added a commit
to ctron/trustify
that referenced
this pull request
Mar 31, 2025
ctron
added a commit
to ctron/trustify
that referenced
this pull request
Mar 31, 2025
github-merge-queue bot
pushed a commit
to guacsec/trustify
that referenced
this pull request
Mar 31, 2025
ctron
added a commit
to guacsec/trustify
that referenced
this pull request
Mar 31, 2025
I don't want to push too much. But that currently prevents me from a new release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the JSON schema lists
OPERATING_SYSTEM, the spec actually saysOPERATING-SYSTEM(dash). This changes to serialize as the spec says, but allows to also read as the JSON schema says.