Skip to content

refactor: remove streamless tutorials #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b0ink merged 6 commits into from
Mar 3, 2026
Merged

refactor: remove streamless tutorials #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6c048f
refactor: ensure tutorial stream is required for new tutorial
b0ink Feb 25, 2026
8b42a3c
Merge branch '10.0.x' into refactor/remove-streamless-tutorials
b0ink Feb 26, 2026
5ea8a81
test: ensure all tests supply tutorial stream abbreviation
b0ink Feb 26, 2026
0820c50
test: ensure tutorial stream abbreviation is supplied
b0ink Feb 26, 2026
ddc79c1
Merge branch '10.0.x' into refactor/remove-streamless-tutorials
b0ink Feb 26, 2026
f5f2c40
Merge branch '10.0.x' into refactor/remove-streamless-tutorials
b0ink Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/api/tutorials_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class TutorialsApi < Grape::API
requires :meeting_location, type: String, desc: 'The tutorials location', allow_blank: false
requires :meeting_day, type: String, desc: 'Day of the tutorial', allow_blank: false
requires :meeting_time, type: String, desc: 'Time of the tutorial', allow_blank: false
optional :tutorial_stream_abbr, type: String, desc: 'Abbreviation of the associated tutorial stream', allow_blank: false
requires :tutorial_stream_abbr, type: String, desc: 'Abbreviation of the associated tutorial stream', allow_blank: false
end
end
post '/tutorials' do
Expand All @@ -83,6 +83,10 @@ class TutorialsApi < Grape::API
tutorial_stream_abbr = tut_params[:tutorial_stream_abbr]
tutorial_stream = unit.tutorial_streams.find_by!(abbreviation: tutorial_stream_abbr) unless tutorial_stream_abbr.nil?

unless tutorial_stream
error!({ error: 'Tutorial must belong to a tutorial stream' }, 403)
end

tutorial = unit.add_tutorial(tut_params[:meeting_day], tut_params[:meeting_time], tut_params[:meeting_location], tutor, campus, tut_params[:capacity], tut_params[:abbreviation], tutorial_stream)

present tutorial, with: Entities::TutorialEntity
Expand Down
Loading