Configurable inactivity timeout #710
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 30 minute idle timeout reboot is mildly annoying as it causes my bike to beep on BLE reconnection. This makes the timeout configurable via the settings webpage. This way the reboot is still in place since it's necessary, but can just occur less often if a user desires it.
Feel free to change the order for where this setting lives on the settings page. I just put it at the bottom for now.
Since this is a new custom characteristic setting, it requires an app update to support it. Not sure what the release process is for that part.
P.S. During development I noticed my
settings.htmlwas not being updated from the official OTA update process; it was a version over 9 months old. I had to use PlatformIO to erase and flash the filesystem manually. Not sure if this was just my device being weird.