Skip to content

Remove use of eval on supported platforms #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove use of eval on supported platforms #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,13 +421,30 @@ function wrapfunction (fn, message) {

site.name = fn.name

// eslint-disable-next-line no-new-func
var deprecatedfn = new Function('fn', 'log', 'deprecate', 'message', 'site',
'"use strict"\n' +
'return function (' + args + ') {' +
'log.call(deprecate, message, site)\n' +
'return fn.apply(this, arguments)\n' +
'}')(fn, log, this, message, site)
var deprecatedfn
var self = this
if (Object.defineProperty) {
try {
deprecatedfn = function () {
'use strict'
log.call(self, message, site)
return fn.apply(this, arguments)
}
Object.defineProperty(deprecatedfn, 'length', { value: fn.length })
Object.defineProperty(deprecatedfn, 'name', { value: fn.name })
} catch (err) {
// some node verions don't allow redefining of length, ignore them and fallback to eval
}
}
if (!deprecatedfn || deprecatedfn.length !== fn.length || deprecatedfn.name !== fn.name) {
// eslint-disable-next-line no-new-func
deprecatedfn = new Function('fn', 'log', 'deprecate', 'message', 'site',
'"use strict"\n' +
'return function (' + args + ') {' +
'log.call(deprecate, message, site)\n' +
'return fn.apply(this, arguments)\n' +
'}')(fn, log, this, message, site)
}

return deprecatedfn
}
Expand Down