data/lua: Drop _msecs from http client settings #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmouse
force-pushed
the
feature/config-rewrite
branch
from
896ecc7 to
760c561
Compare
sirainen
requested changes
Nov 7, 2024
cmouse
force-pushed
the
lua-http-settings
branch
from
9a5da4b to
650d043
Compare
cmouse
force-pushed
the
feature/config-rewrite
branch
from
760c561 to
d278613
Compare
cmouse
force-pushed
the
lua-http-settings
branch
from
650d043 to
fc79dd7
Compare
sirainen
requested changes
Nov 19, 2024
They are now parsed via settings parser, which does not have msecs suffix.
cmouse
force-pushed
the
lua-http-settings
branch
from
16772af to
2ef2534
Compare
sirainen
approved these changes
Nov 19, 2024
cmouse
force-pushed
the
lua-http-settings
branch
from
2ef2534 to
1f56fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are now parsed via settings parser, which does not have msecs suffix.
JIRA: DOV-6912